Fix sagenb doctesting

[qed777]

We have not been doctesting SageNB files as often as we test Sage files.

Please apply

• attachment: trac_7650-scripts_doctest_force_lib_v5.patch to the scripts repository. This adds two options to sage -t: -sagenb tests all SageNB files and -force_lib tests files as if they live in SAGE_ROOT/devel/sage, i.e., in the Sage library.

• attachment: trac_7650-sagenb_doctesting_v6.patch and attachment: trac_7650-reviewer_v2.patch to the sagenb repository. This fixes broken SageNB tests.

and replace SAGE_ROOT/makefile with

• attachment: makefile. This makes make test and make ptest test all SageNB files, too.

Dependencies: Sage 4.3.1.alpha1, #7269.

CC: @williamstein @TimDumol @mwhansen @jasongrout

Component: notebook

Author: Mitesh Patel

Reviewer: Tim Dumol

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7650

[qed777]

comment:1

Part of the problem is that notebook directories now need to end in .sagenb.

I'm working on a patch for this and whatever other problems I can fix.

[qed777]

comment:2

sage -t -verbose "notebook.py"                              
Traceback (most recent call last):
  File "/home/.sage//tmp/.doctest_notebook.py", line 18, in <module>
    from notebook import *
  File "/home/.sage/tmp/notebook.py", line 38, in <module>
    import css          # style
ImportError: No module named css
         [2.5 s]
exit code: 1024
 
----------------------------------------------------------------------
The following tests failed:


        sage -t -verbose "notebook.py"
Total time for all tests: 2.5 seconds

Adding

import sys
sys.path.append('/home/sage/notebook/sagenb/sagenb')
sys.path.append('/home/sage/notebook/sagenb/sagenb/notebook')

to the top of notebook.py allows testing to proceed. I'm not sure about a real solution.

[qed777]

Attachment: trac_7650-sagenb_doctesting.patch.gz

Add --force_lib option to sage-doctest. Use os.path.join. scripts repo.

[qed777]

Fix sagenb doctests. sagenb repo.

[qed777]

comment:3

Attachment: trac_7650-scripts_doctest_force_lib.patch.gz

Please note: The attachments (or their descriptions) are switched. I apologize for this.

Anyway, with the scripts repository patch, we can do, e.g.,

$ sage -t --force_lib sagenb/

With the sagenb repository patch applied to #7625 + #7483 + #7482 + #7514 + #7648, all tests but 3 pass. The failures are in sagenb/misc/sageinspect.py (cf. #7514). The Selenium tests still pass.

Remarks:

• I hope I did not create false-negatives.
• This sage-notebook thread might be relevant to some tests that evaluate cells.
• I "untabified" cell.py, worksheet.py, notebook.py, and twist.py.
• I added 'nodoctest' to simple/twist.py, since at least one test appears to hang indefinitely. I don't know why.
• Feel free to lower the priority.

[qed777]

Author: Mitesh Patel

[qed777]

comment:5

Should we add, e.g.,

sage -t --force_lib $SAGE_ROOT/local/lib/python/site-packages/sagenb

to $SAGE_ROOT/makefile? Or sage-test?