Cleanup of crystal code: cartan_type now a method rather than attribute

[anneschilling]

Crystals: cartan_type is a method

• Changed the API to have cartan type as a method rather than attribute
• Systematically use .parent() instead of ._parent
• Minor doc improvements

CC: @sagetrac-sage-combinat

Component: combinatorics

Issue created by migration from https://trac.sagemath.org/ticket/5729

[anneschilling]

Attachment: crystal-cleanup-track.patch.gz

changed according to Nicolas' suggestions

[anneschilling]

comment:1

Attachment: crystal-5729-track.patch.gz

[nthiery]

comment:2

Attachment: crystal-5729-track.2.patch.gz

Final version of the patch uploaded:

• fixes 2/3 remaining calls to parent()
• Micro doc improvements

[nthiery]

Description changed:

--- 
+++ 
@@ -1,2 +1,4 @@
-Changed the user interface to have cartan type as a method
-rather than attribute
+Crystals: cartan_type is a method
+- Changed the API to have cartan type as a method rather than attribute
+- Systematically use .parent() instead of ._parent
+- Minor doc improvements

[sagetrac-mabshoff]

comment:5

Huh? This ticket has not been merged.

Cheers,

Michael