Auto browser open of notebook does not open to a valid url when interface=""

[williamstein]

On Thu, 02 Apr 2009 at 11:53PM -0700, Ondrej Certik wrote:
>
> Hi,
>
[...]
> sage: notebook(secure=False, address="")
> [...]
>
> and it starts firefox on the local machine with this address:
>
> http://[www.:8000.com]/?startup_token=41e2a34e89e40139333a8113e9be2a50
>
> which obviously fails. This also happens with sage 3.2.3 (I didn't try
> other versions).

This has been around for a while; I haven't filed a ticket for it, since
I just retype the URL.

It used to be in the notebook that address="" was an error. Then when we switched to twisted, it suddenly meant "listen on all interfaces". Now it's a common option to give.

CC: @sagetrac-acleone

Component: notebook

Author: Tim Dumol

Reviewer: Alex Leone

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/5675

[qed777]

comment:1

This ticket subsumes #5263.

[qed777]

comment:2

There is socket.getfqdn, but does it help? On boxen:

sage: import socket
sage: socket.getfqdn()
'localhost'
sage: socket.gethostbyname_ex(socket.gethostname())
('localhost', ['boxen', 'boxen'], ['127.0.0.1', '128.208.160.197'])

On a local Linux machine, I get

sage: import socket
sage: socket.getfqdn()
'localhost.localdomain'
sage: socket.gethostbyname_ex(socket.gethostname())
('localhost.localdomain', ['localhost', 'foo'], ['127.0.0.1'])

all of which happen to be in /etc/hosts.

What if we just add an option published_host=* (or a variation) and insert it into URLs for published (and remote!) worksheets when interface=*? We could print a warning or raise an error, if both are left empty.

[TimDumol]

Description changed:

--- 
+++ 
@@ -20,10 +20,3 @@
 ```
 
 It used to be in the notebook that address="" was an error.  Then when we switched to twisted, it suddenly meant "listen on all interfaces".  Now it's a common option to give.  
-
-The two places I know of where the address is given are: (1) when popping up a web browser pointed at the notebook, and (2) when publishing a worksheet and it shows the URL where people can get the published version.
-
-Ideas:
-* If one gives address="", everywhere else, set the address to the fully qualified domain name.  How to get that in Python?
-* If one gives address="", simply never automatically pop up a viewer, and doesn't display the URL for published worksheets (since it is wrong).  If people want proper URL's they shouldn't be lazy with their address= option.
-* Make address="" an error, and require the user to give a proper fully qualified name. 

[TimDumol]

comment:3

Renaming this to a more appropriate title.

[TimDumol]

Attachment: trac_5675-address-launch.patch.gz

This sets the hostname to localhost if interface="" when launching the page

[TimDumol]

Author: Tim Dumol

[TimDumol]

comment:4

This fixes the issue described.

[sagetrac-acleone]

comment:5

LGTM. See #5263. This bug is only for a blank option passed to sage -n interface=''.