attach command doesn't handle carriage returns correctly

[sagetrac-mhampton]

This problem is specific to attaching files ending with ".py" in the notebook. It does not seem to affect the command-line, or files ending with ".sage". Some files that are moved around from different filesystems and editors end up having end-of-line commands that look like: "\r\n". These raise a syntax error when attached. Here is an example (of course you need to change the path):

testfile = file('/home/marshall/Desktop/misc/testrn.py','w')
testfile.write('my_var = 2\r\n')
testfile.close()
attach /home/marshall/Desktop/misc/testrn.py

    Syntax Error:
        attach /home/marshall/Desktop/misc/testrn.py

Component: notebook

Keywords: attach

Issue created by migration from https://trac.sagemath.org/ticket/5206

[sagetrac-mabshoff]

comment:1

No ticket without patches that aren't blockers should be assigned to 3.3 or 3.4 at this stage.

Cheers,

Michael

[TimDumol]

comment:2

This seems to be fixed already (probably by #7514).

[TimDumol]

Work Issues: Close/mark as fixed?

[TimDumol]

Changed work issues from Close/mark as fixed? to none