py3: fix bugs in pynac with handling Python 3 ints

[embray]

Upstream PRs: pynac/pynac#299 pynac/pynac#302

Upstream: Fixed upstream, in a later stable release.

CC: @fchapoton @rwst

Component: python3

Keywords: pynac

Issue created by migration from https://trac.sagemath.org/ticket/24561

[embray]

Upstream: Reported upstream. No feedback yet.

[embray]

Changed upstream from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

[embray]

Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.

[embray]

comment:4

There is another bug I just found that only cropped up once I rebased my Python 3 branch to include #24247.

The problem seems to lie in the assumption of all Python integer-like values will be successfully converted to a native int type (either long or mpz_t). Otherwise methods like numeric::is_small_power don't work properly, and some other things break down too.

[rwst]

comment:5

Replying to @embray:

There is another bug I just found that only cropped up once I rebased my Python 3 branch to include #24247.

The problem seems to lie in the assumption of all Python integer-like values will be successfully converted to a native int type (either long or mpz_t). Otherwise methods like numeric::is_small_power don't work properly, and some other things break down too.

Actually numeric::is_small_power is called only once (from log_eval) and Python numerics are not down-converted at all. So, to be able to confirm the bug you better please give me the concrete example.

[embray]

comment:6

Maybe that's not exactly it, but there was something like that. Basically the issue is that Python 2 longs / Python 3 ints were staying as Python objects and not being converted to either a C long or mpz_t. I have a patch I just forgot to post it.

[embray]

comment:7

See pynac/pynac#302

[embray]

Description changed:

--- 
+++ 
@@ -1 +1 @@
-**Upstream PR:** https://github.com/pynac/pynac/pull/299
+**Upstream PRs:** https://github.com/pynac/pynac/pull/299 https://github.com/pynac/pynac/pull/302

[fchapoton]

Changed upstream from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.

[fchapoton]

comment:8

#24668 updates pynac, so we can close this one maybe ?