Infinity crystal of tableaux

[bsalisbury1]

Implements infinity crystal of tableaux in types A, B, C, D, and G.

Apply: attachment: trac_14192-infinity_crystal-bs.patch

CC: @tscrim @anneschilling @sagetrac-sage-combinat

Component: combinatorics

Keywords: crystal, tableaux

Author: Ben Salisbury, Travis Scrimshaw

Reviewer: Anne Schilling

Merged: sage-5.10.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14192

[tscrim]

comment:2

Attachment: trac_14192-infinity_crystal-review-ts.patch.gz

I've uploaded a small review patch which makes some small tweaks/fixes to the documentation.

[anneschilling]

comment:3

Hi Ben and Travis,

Thanks for your work on this. Here are a couple of comments:

• Could you please fold the two patches? That makes it easier to review!

• In the title "\mathcal{B}(\infty) Crystals of Tableaux" specify the types for which this works.

• There are trailing white spaces. Please remove them!

• Why don't you put the Element class into the parent class (by indentation)? See for example how this is done in Littelmann paths. Also, the parent class should come first!

• In string_parameters, the Examples are indented wrongly!

Please make these changes and then I'll look again!

Anne

[bsalisbury1]

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 Implements infinity crystal of tableaux in types A, B, C, D, and G.
 
-
+Apply: [attachment: trac_14192-infinity_crystal-bs.patch]

[bsalisbury1]

comment:4

Folded in review. Made appropriate changes.

For patchbot:

Apply: trac_14192-infinity_crystal-bs.patch

[anneschilling]

comment:5

Thanks for making the changes! Could you also move the patch past 14143 in the sage-combinat queue and make the appropriate rebases there? 14252 is almost ready to go in as well, so we can make a dependence either way for that patch (but I think 14143 needs a little longer due to the plot patch it depends on).

Thanks!

Anne

[bsalisbury1]

comment:6

Made it so this does not depend on #14252 and #14252 (in the combinat queue) did not have any dependency on this patch (at least there was no fuzz that Travis and I saw).

For patchbot:

Apply trac_14192-infinity_crystal-bs.patch

[bsalisbury1]

Dependencies: #14143

[anneschilling]

comment:7

Replying to @bsalisbury1:

Made it so this does not depend on #14252 and #14252 (in the combinat queue) did not have any dependency on this patch (at least there was no fuzz that Travis and I saw).

For patchbot:

Apply trac_14192-infinity_crystal-bs.patch

Did you get this backwards? There should not be a dependency on 14143, but rather on 14252?

[tscrim]

Changed dependencies from #14143 to #14252