style: apply/fix more clippy lints (from cargo::nursery) (2/2) #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
clippy-tightening-2
branch
from
64a0dd9 to
34b7430
Compare
| impl AtaDevice<'_> { | ||
| #[allow(clippy::needless_pass_by_ref_mut)] // cast to mutable ptr | ||
| const fn proto_mut(&mut self) -> *mut AtaPassThruProtocol { | ||
| ptr::from_ref(self.proto).cast_mut() |
There was a problem hiding this comment.
I haven't tested this, but could we change the code to this and drop the allow?
Suggested change
| ptr::from_ref(self.proto).cast_mut() | |
| &raw mut self.proto |
And same for the other functions below.
There was a problem hiding this comment.
doesn't work unfortunately
error[E0596]: cannot borrow `*self.proto` as mutable, as it is behind a `&` reference
--> uefi/src/proto/ata/pass_thru.rs:111:9
|
111 | &raw mut *self.proto
| ^^^^^^^^^^^^^^^^^^^^ cannot borrow as mutable
In general, I'm a little concerned as the proto_mut function should be unsafe, including a # Safety comment
There was a problem hiding this comment.
I see what you mean, I missed that the proto field is a const reference. I've put up #1782 to hopefully resolve this in a sound way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1761
Checklist