Skip to content

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Feb 18, 2025

Copy link
Member

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be fine to return None from guess_os_stack when procfs isn't available, but in principle it also doesn't change that for most intents and purposes systems configured that way are sorta broken for the purposes of *-linux-gnu targets at least.

@lovasoa
Copy link
Contributor Author

lovasoa commented Feb 19, 2025

@nagisa I reorganized guess_os_stack to have separate files per backend, addressed your comments, and added more error handling where it was missing on other platforms.

@nagisa nagisa merged commit 5eed05f into rust-lang:master Feb 21, 2025
155 checks passed
@lovasoa lovasoa deleted the improve_error_handling branch February 21, 2025 13:04
@lovasoa
Copy link
Contributor Author

lovasoa commented Feb 21, 2025

Great, thank you very much @nagisa !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion error: when pthread returns an error, this library crashes the entire program

2 participants