Skip to content

Add a test for existence of [workspace] in compile benchmarks #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2025
Merged

Add a test for existence of [workspace] in compile benchmarks #2144

merged 2 commits into from
May 29, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented May 29, 2025

Some compile benchmarks didn't have [workspace] in their Cargo.toml (discovered here). This PR fixes that and adds a test for it, so that it doesn't happen again.

@Kobzol Kobzol requested a review from lqd May 29, 2025 05:39
@Kobzol Kobzol mentioned this pull request May 29, 2025
Merged
lqd
lqd approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, I also had to do this manually to test the cranelift benchmark but hadn’t had the time to fix it yet. r=me with CI green

@Kobzol Kobzol enabled auto-merge May 29, 2025 05:57
@Kobzol Kobzol merged commit feba2ed into rust-lang:master May 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqd lqd lqd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kobzol @lqd