Fix StringReader references
#2230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most files names are relatively explicit and probably don't need to be explicited. However `rt.rs` is really not clear, and I believe it clarifies the text to indicate this is runtime service implementation.
* Add link in salsa * Update src/salsa.md Co-authored-by: León Orell Valerian Liehr <[email protected]> * Update src/salsa.md Co-authored-by: León Orell Valerian Liehr <[email protected]> --------- Co-authored-by: León Orell Valerian Liehr <[email protected]>
Co-authored-by: Yuki Okushi <[email protected]>
since this method has been renamed in rustc. Also remove a link to documentation in error-guaranteed.md because it was unused
Co-authored-by: Tshepang Mbambo <[email protected]>
These were removed in 2021. rust-lang/rust#85993
* add implied bounds doc * lazy type aliases also have explicit implied bounds
* add opaque types doc * summary
* make shell.nix better * Mention using RUST_BOOTSTRAP_CONFIG * Move things to `buildInputs` and add `glibc.out glibc.static` This fixes the nofile-limit.rs UI test. * short lines for the short line fans * Fix pkgs
* Add some more details on feature gating * Apply suggestions from code review --------- Co-authored-by: Ross Smyth <[email protected]> Co-authored-by: Nilstrieb <[email protected]>
Co-authored-by: nora <[email protected]>
But accept test names that include non-prefix issue number.
Co-authored-by: Jieyou Xu <[email protected]> Co-authored-by: Tbkhi <[email protected]>
fix conflicting link names that lead to the "chapter link" leading to rustdoc's source code instead.
* Fix broken link in syntax-intro.md * Fix broken link in tests/compiletest.md * Fix incorrectly formatted reference-style link in compiler-src.md * Fix broken links to rustc-driver.md to point to rustc-driver/intro.md * Define URLs for incomplete links to rustc sources in stabilization_guide.md * Define link to coherence.md for incomplete link in solve/invariants.md
Co-authored-by: Jieyou Xu <[email protected]>
`StringReader` was renamed `Lexer` in rust-lang/rust#133070. This commit updates the guide accordingly.
|
Whoa, git failure on my end. Let me fix this up. |
|
Ok, this was already fixed in #2208. |
|
🤏 close to getting right to the top spot of contributors to the dev guide by line number 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
80 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringReaderwas renamedLexerin rust-lang/rust#133070. This commit updates the guide accordingly.