Add some explanation of lowering #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-i-m
suggested changes
Jun 2, 2018
There was a problem hiding this comment.
This is great! It fills in a long-standing gap :)
A couple of minor requests
- please add this in
SUMMARY.mdas a subchapter of the HIR chapter (so it can be found from the Table of Contents) - Could you also add a link to the end of the first paragraph of the HIR chapter. Something like "For more info on lowering, see ..."
Thanks!
|
sure. Note that I just pushed this because @QuietMisdreavus was having the exact troubles I had and I already had this half finished chapter. I'll fix up your nits next week along with some more information on DefId generation during lowering |
|
@oli-obk Ping :) |
1 similar comment
|
@oli-obk Ping :) |
|
Addressed review comments and added some |
oli-obk
changed the title
|
cc #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @QuietMisdreavus