Skip to content

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented Oct 11, 2013

This patch removes the code responsible for handling older CrateMap versions (as discussed during #9593). Only the new (safer) layout is supported now.

@alexcrichton
Copy link
Member

Yay red diffs! While you're at it, there's also a few other things which I think could get reorganized.

  • Could you move the extern static CRATE_MAP business to just inside the non-windows get_crate_map?
  • I think you can remove the iter_module_map function b/c it's so simple and natural now

Otherwise, looks good to me, thanks!

@fhahn
Copy link
Contributor Author

fhahn commented Oct 11, 2013

I reorganized the things mentioned above.

@fhahn
Copy link
Contributor Author

fhahn commented Oct 11, 2013

I think while moving extern static CRATE_MAP to the non-windows get_crate_map I forgot to delete a #[cfg(not(windows))] which lead to a failure of the windows build. I've pushed an updated version of the commit

bors added a commit that referenced this pull request Oct 11, 2013
…hton

This patch removes the code responsible for handling older CrateMap versions (as discussed during #9593). Only the new (safer) layout is supported now.
@bors bors closed this Oct 11, 2013
@bors bors merged commit f3b1f79 into rust-lang:master Oct 11, 2013
@fhahn fhahn deleted the remove-old-cratemap-code branch January 7, 2014 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants