Add an explicit Span field to OutlivesConstraint
#96236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
This improves the output for #95686, but we still emit two 'implementation is not general enough' errors. |
This comment has been minimized.
This comment has been minimized.
Aaron1011
force-pushed
the
constraint-debug
branch
from
ac43628 to
47a8174
Compare
This comment has been minimized.
This comment has been minimized.
|
r=me with tests blessed |
Previously, we would retrieve the span from the `Body` using the `locations` field. However, we may end up changing the `locations` field when moving a constraint from a promoted to a different body. We now store the original `Span` in a dedication field, so that changes to the `locations` do not affect the quality of our diagnostics.
Aaron1011
force-pushed
the
constraint-debug
branch
from
47a8174 to
611a06a
Compare
|
@bors r=jackh726 |
|
📌 Commit 611a06a has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 20, 2022
Add an explicit `Span` field to `OutlivesConstraint` Previously, we would retrieve the span from the `Body` using the `locations` field. However, we may end up changing the `locations` field when moving a constraint from a promoted to a different body. We now store the original `Span` in a dedication field, so that changes to the `locations` do not affect the quality of our diagnostics.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 21, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#90630 (Create real parser for search queries) - rust-lang#96193 ([fuchsia] Add implementation for `current_exe`) - rust-lang#96196 (Remove assertion that all paths in `ShouldRun` exist) - rust-lang#96228 (Fix locations for intrinsics impls and change to links) - rust-lang#96236 (Add an explicit `Span` field to `OutlivesConstraint`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would retrieve the span from the
Bodyusingthe
locationsfield. However, we may end up changing thelocationsfield when moving a constraint from a promotedto a different body.
We now store the original
Spanin a dedication field, so thatchanges to the
locationsdo not affect the quality of ourdiagnostics.