Constify Index{,Mut} for [T], str, and [T; N]
#94657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
fee1-dead
force-pushed
the
const_slice_index
branch
from
5247cdb to
c6f987b
Compare
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
const_slice_index
branch
from
c6f987b to
4654a91
Compare
rustbot
added
the
T-compiler
oli-obk
added
the
S-blocked
|
Hold up 😄 I got like 5 PRs in my review queue that are blocked on the nebulous "unclear if libs and lang are happy with our extensive testing here". I really want to progress, so maybe you and I should come up with a less technical doc and a more "here's what users want to do and how they can do it now and how they can do it with 🌈🦄-const-eval" |
oli-obk
added
const-hack
and removed
S-blocked
|
ok, went through the queue and this PR. Since it does not add new bounds, there are no rustdoc or diagnostics visible changes. The @bors r+ |
|
📌 Commit 4654a91 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 9, 2022
Constify `Index{,Mut}` for `[T]`, `str`, and `[T; N]`
Several panic functions were rewired (via `const_eval_select`) to simpler implementations that do not require formatting for compile-time usage.
r? ``@oli-obk``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 10, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#92150 (Improve suggestion when casting usize to (possibly) wide pointer) - rust-lang#94635 (Merge `#[deprecated]` and `#[rustc_deprecated]`) - rust-lang#94657 (Constify `Index{,Mut}` for `[T]`, `str`, and `[T; N]`) - rust-lang#94746 (diagnostics: use rustc_on_unimplemented to recommend `[].iter()`) - rust-lang#94788 (Account for suggestions for complete removal of lines) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
yvt
added a commit
to r3-os/r3
that referenced
this pull request
Mar 21, 2022
This feature, which covers the `const fn` version of `<[T]>:: get[_unchecked][_mut]`, was added by [rust-lang/rust#94657][1]. [1]: rust-lang/rust#94657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several panic functions were rewired (via
const_eval_select) to simpler implementations that do not require formatting for compile-time usage.r? @oli-obk