Skip to content

Implement TryFrom<&'_ mut [T]> for [T; N] #91086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Implement TryFrom<&'_ mut [T]> for [T; N] #91086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72b411f
Implement `TryFrom<&'_ mut [T]>` for `[T; N]`
rhysd Nov 20, 2021
66e0523
Update version in `stable` attribute
rhysd Nov 20, 2021
ac083c6
Reborrow mut slice instead of converting it with `as_ref`
rhysd Nov 21, 2021
16711fe
Update stabilization version of try_from_mut_slice_to_array
m-ou-se Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions library/core/src/array/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,18 @@ where
}
}

#[stable(feature = "try_from_mut_slice_to_array", since = "1.59.0")]
impl<T, const N: usize> TryFrom<&mut [T]> for [T; N]
where
T: Copy,
{
type Error = TryFromSliceError;

fn try_from(slice: &mut [T]) -> Result<[T; N], TryFromSliceError> {
<Self>::try_from(&*slice)
}
}

#[stable(feature = "try_from", since = "1.34.0")]
impl<'a, T, const N: usize> TryFrom<&'a [T]> for &'a [T; N] {
type Error = TryFromSliceError;
Expand Down
13 changes: 12 additions & 1 deletion library/core/tests/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,22 @@ fn array_try_from() {
($($N:expr)+) => {
$({
type Array = [u8; $N];
let array: Array = [0; $N];
let mut array: Array = [0; $N];
let slice: &[u8] = &array[..];

let result = <&Array>::try_from(slice);
assert_eq!(&array, result.unwrap());

let result = <Array>::try_from(slice);
assert_eq!(&array, &result.unwrap());

let mut_slice: &mut [u8] = &mut array[..];
let result = <&mut Array>::try_from(mut_slice);
assert_eq!(&[0; $N], result.unwrap());

let mut_slice: &mut [u8] = &mut array[..];
let result = <Array>::try_from(mut_slice);
assert_eq!(&array, &result.unwrap());
})+
}
}
Expand Down