Improve and test cross-crate hygiene #90202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always use the ExpnId serialized to `tables` - Use the Id for traits and enums from other crates in resolution.
This will potentially hide a few correct suggestions, but importing these items from another module is not generally possible.
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
matthewjasper
force-pushed
the
xcrate-hygiene
branch
from
35ee06e to
fabede1
Compare
|
Could you add a couple of sentences of text to every test, explaining what that test aims to check? |
petrochenkov
added
S-waiting-on-author
apiraino
added
the
T-compiler
This avoids having to decode 2 `Lazy`s when decoding a modules exports.
petrochenkov
added
S-waiting-on-review
|
Thanks! |
|
📌 Commit a76a2d4 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#90156 (Remove underlines from non-top docblocks.) - rust-lang#90183 (Show all Deref implementations recursively) - rust-lang#90202 (Improve and test cross-crate hygiene) - rust-lang#90375 (Use `is_global` in `candidate_should_be_dropped_in_favor_of`) - rust-lang#90399 (Skipping verbose diagnostic suggestions when calling .as_ref() on type not implementing AsRef) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc_resolve, this was already being used for resolution in typeckr? @petrochenkov