Skip to content

Force warn improvements #88134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2021
Merged

Force warn improvements #88134

merged 2 commits into from
Aug 21, 2021

Conversation

rylev
Copy link
Member

@rylev rylev commented Aug 18, 2021

As part of stablization of the --force-warn option (#86516) I've made the following changes:

  • Error when the warnings lint group is based to the --force-warn option
  • Tests have been updated to make it easier to understand the semantics of --force-warn

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2021
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 19, 2021

📌 Commit d70056e has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2021
@bors
Copy link
Collaborator

bors commented Aug 21, 2021

⌛ Testing commit d70056e with merge 99b73e8...

@bors
Copy link
Collaborator

bors commented Aug 21, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 99b73e8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2021
@bors bors merged commit 99b73e8 into rust-lang:master Aug 21, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 21, 2021
@bors bors mentioned this pull request Aug 21, 2021
Merged
@rylev rylev deleted the force-warn-improvements branch August 30, 2021 09:37
@m-ou-se m-ou-se mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rylev @nikomatsakis @bors @rust-highfive @rustbot