Skip to content

Point only at generic arguments when they are unexpected #79591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

Point only at generic arguments when they are unexpected #79591

merged 1 commit into from
Jan 27, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Dec 1, 2020

No description provided.

@rust-highfive
Copy link
Contributor

r? @ecstatic-morse

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2020
oli-obk
oli-obk reviewed Dec 1, 2020
View reviewed changes
@oli-obk
Copy link
Contributor

oli-obk commented Dec 1, 2020

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Dec 3, 2020

r=me with a test with two generics within a single module path

@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-diagnostics Area: Messages for errors, warnings, and lints and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2021
@estebank estebank force-pushed the unexpected-generics branch from 0b98893 to 2e846d6 Compare January 27, 2021 00:00
@estebank
Copy link
Contributor Author

@bors r=oli-obk

Added test case and rebased on top of recent master.

@bors
Copy link
Collaborator

bors commented Jan 27, 2021

📌 Commit 2e846d6 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#79591 - estebank:unexpected-generics, r=oli…
ccbd311 
…-obk

Point only at generic arguments when they are unexpected
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 27, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 27, 2021
@Dylan-DPC
Rollup merge of rust-lang#79591 - estebank:unexpected-generics, r=oli…
fcbf3c0 
…-obk

Point only at generic arguments when they are unexpected
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 27, 2021
Closed
@bors
Copy link
Collaborator

bors commented Jan 27, 2021

⌛ Testing commit 2e846d6 with merge 742c972...

@bors
Copy link
Collaborator

bors commented Jan 27, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 742c972 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 27, 2021
@bors bors merged commit 742c972 into rust-lang:master Jan 27, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 27, 2021
@estebank estebank deleted the unexpected-generics branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
A-diagnostics Area: Messages for errors, warnings, and lints merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
7 participants
@estebank @rust-highfive @oli-obk @bors @ecstatic-morse @camelid @rustbot