Skip to content

Conversation

RalfJung
Copy link
Member

Make sure we find this issue even without const qualification.

r? @oli-obk @ecstatic-morse

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Apr 27, 2020

Not sure if ui tests support this, but: Can you try making the test run once with unleash and once without?

@RalfJung RalfJung force-pushed the unleash-recursive-zst branch from 83a511e to 3bce639 Compare April 27, 2020 11:40
@RalfJung
Copy link
Member Author

I think this should do it.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 27, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 27, 2020

📌 Commit 3bce639 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#67841 (Add Read/Write::can_read/write_vectored)
 - rust-lang#71524 (Minimize parameter of coerce_borrowed_pointer())
 - rust-lang#71558 (Cleanup and document `-Z tls-model` )
 - rust-lang#71578 (linkchecker: fix typo in main.rs)
 - rust-lang#71596 (Fix broken link in `QPath` documentation)
 - rust-lang#71604 (make recursive-zst test unleashed)
 - rust-lang#71605 (No need to whitelist E0750 anymore)

Failed merges:

r? @ghost
@bors bors merged commit efed49b into rust-lang:master Apr 28, 2020
@RalfJung RalfJung deleted the unleash-recursive-zst branch April 30, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants