Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 15, 2019

Extracted from #65355.
This just moves some tests around to make things better categorized.

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2019
@varkor
Copy link
Contributor

varkor commented Oct 15, 2019

Any reason the src/test/run-fail tests can't be moved to src/test/ui with // run-fail?

@Centril
Copy link
Contributor Author

Centril commented Oct 15, 2019

Would be nice! Let me see if that can be done. :)

@Centril
Copy link
Contributor Author

Centril commented Oct 15, 2019

@varkor I moved the run-fail/never_type tests to ui/never_type. The remainder of run-fail/ should also be moved but I think we can do that in a follow up to categorize them properly.

@varkor
Copy link
Contributor

varkor commented Oct 15, 2019

r=me after squashing when CI passes.

Also move {run-fail -> ui}/never_type
@Centril
Copy link
Contributor Author

Centril commented Oct 15, 2019

@bors r=varkor

@bors
Copy link
Collaborator

bors commented Oct 15, 2019

📌 Commit 1fb8cfb has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
Organize `never_type`  tests

Extracted from rust-lang#65355.
This just moves some tests around to make things better categorized.

r? @varkor
Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
Organize `never_type`  tests

Extracted from rust-lang#65355.
This just moves some tests around to make things better categorized.

r? @varkor
tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019
Organize `never_type`  tests

Extracted from rust-lang#65355.
This just moves some tests around to make things better categorized.

r? @varkor
bors added a commit that referenced this pull request Oct 15, 2019
Rollup of 14 pull requests

Successful merges:

 - #64603 (Reducing spurious unused lifetime warnings.)
 - #64623 (Remove last uses of gensyms)
 - #65235 (don't assume we can *always* find a return type hint in async fn)
 - #65242 (Fix suggestion to constrain trait for method to be found)
 - #65265 (Cleanup librustc mir err codes)
 - #65293 (Optimize `try_expand_impl_trait_type`)
 - #65307 (Try fix incorrect "explicit lifetime name needed")
 - #65308 (Add long error explanation for E0574)
 - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members)
 - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.)
 - #65402 (Add troubleshooting section to PGO chapter in rustc book.)
 - #65425 (Optimize `BitIter`)
 - #65438 (Organize `never_type`  tests)
 - #65444 (Implement AsRef<[T]> for List<T>)

Failed merges:

 - #65390 (Add long error explanation for E0576)

r? @ghost
@bors bors merged commit 1fb8cfb into rust-lang:master Oct 16, 2019
@Centril Centril deleted the almost branch October 25, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants