Skip to content

Conversation

czipperz
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 12, 2019
@timvermeulen
Copy link
Contributor

which call next internally. Each of these methods delegates to the try_fold implementation.

This seems a bit contradictory, maybe it's better to be more explicit about them delegating to try_fold which in turn has a default implementation that calls next repeatedly.

@scottmcm
Copy link
Member

This seems like a good change, but overriding try_fold is still unstable, so I don't know whether the convention is to mention things that can't be used on stable in the documentation of stable things.

@czipperz
Copy link
Contributor Author

@scottmcm Where is the unstable attribute?

@scottmcm
Copy link
Member

@czipperz on the Try trait, which you have to mention in the signature.

@czipperz
Copy link
Contributor Author

czipperz commented Jul 25, 2019

Mmh. Do you have any recommendations for the current solution?

@czipperz
Copy link
Contributor Author

I'm going to close this and post a comment on the tracking issues to reopen once it stabilizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants