Recover from parse error in tuple syntax #59453
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
This is an ICE regression test, so I'm disinclined to change it to avoid the new errors.
There was a problem hiding this comment.
These new errors are unfortunate (caused by the changes in parse_bottom_expr) :-/
estebank
force-pushed
the
recover-tuple-parse
branch
from
15ec821 to
5dd531e
Compare
This comment has been minimized.
This comment has been minimized.
|
r=me with @Centril's comments addressed or not |
petrochenkov
added
S-waiting-on-author
estebank
force-pushed
the
recover-tuple-parse
branch
from
5dd531e to
9ea6790
Compare
There was a problem hiding this comment.
As a follow up to this PR, could you point out the feature gate here?
There was a problem hiding this comment.
@Centril, do we want to nudge people towards enabling type ascription, particularly when the most common case for this error is caused by incorrect syntax, not an attempt to use the nightly feature?
There was a problem hiding this comment.
@estebank I don't think it wold be particularly invasive to point it out... It could be as simple as:
= note: #![feature(type_ascription)] lets you annotate an expression with a type: `<expr>: <type>`
This comment has been minimized.
This comment has been minimized.
|
r=me with the failing test updated |
estebank
force-pushed
the
recover-tuple-parse
branch
from
1729d7a to
3592079
Compare
|
@bors r=petrochenkov |
|
📌 Commit 3592079 has been approved by |
bors
added
S-waiting-on-bors
…rochenkov Recover from parse error in tuple syntax
…rochenkov Recover from parse error in tuple syntax
Rollup of 10 pull requests Successful merges: - #59376 (RFC 2008: Enum Variants) - #59453 (Recover from parse error in tuple syntax) - #59455 (Account for short-hand field syntax when suggesting borrow) - #59499 (Fix broken download link in the armhf-gnu image) - #59512 (implement `AsRawFd` for stdio locks) - #59525 (Whitelist some rustc attrs) - #59528 (Improve the dbg! macro docs ) - #59532 (In doc examples, don't ignore read/write results) - #59534 (rustdoc: collapse blanket impls in the same way as normal impls) - #59537 (Fix OnceWith docstring.) Failed merges: r? @ghost
6 participants
No description provided.