Make visit_clobber panic-safe.
#58630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Sorry, I meant to say this in the description: (I have updated the description to match that.) |
|
Will this properly report ICEs if they happen inside |
petrochenkov
added
S-waiting-on-author
Centril
reviewed
Feb 22, 2019
@petrochenkov: It shows the panic message like you'd expect. See here for an example. |
nnethercote
force-pushed
the
fix-fold_clobber
branch
from
9610806 to
eddd07c
Compare
|
@bors r+ rollup |
|
📌 Commit eddd07c has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 27, 2019
…rochenkov Make `visit_clobber` panic-safe. Local measurements indicate the performance effect is negligible. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 27, 2019
…rochenkov Make `visit_clobber` panic-safe. Local measurements indicate the performance effect is negligible. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 27, 2019
…rochenkov Make `visit_clobber` panic-safe. Local measurements indicate the performance effect is negligible. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 27, 2019
…rochenkov Make `visit_clobber` panic-safe. Local measurements indicate the performance effect is negligible. r? @petrochenkov
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 27, 2019
…rochenkov Make `visit_clobber` panic-safe. Local measurements indicate the performance effect is negligible. r? @petrochenkov
bors
added a commit
that referenced
this pull request
Feb 27, 2019
Rollup of 14 pull requests Successful merges: - #58075 (Fix for issue #58050) - #58627 (rustdoc: move collapse and unindent docs passes earlier) - #58630 (Make `visit_clobber` panic-safe.) - #58678 (Deny `async fn` in 2015 edition) - #58680 (Fix an indexing error when using `x.py help`) - #58703 (Fix copy-pasted typo for read_string return value) - #58744 (Update dlmalloc to 0.1.3) - #58746 (std: docs: Disable running several Stdio doctests) - #58748 (update scoped_tls to 1.0) - #58749 (Reduce Repetitions of (n << amt) >> amt) - #58752 (Update string_cache_codegen to 0.4.2) - #58755 (Clarify `rotate_{left,right}` docs) - #58757 (Normalize the type Self resolves to in an impl) - #58761 (Add tracking issue for the unwind attribute) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local measurements indicate the performance effect is negligible.
r? @petrochenkov