Skip to content

libpanic_unwind => 2018 #58110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2019
Merged

libpanic_unwind => 2018 #58110

merged 3 commits into from
Feb 14, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 3, 2019

Transitions libpanic_unwind to Rust 2018; cc #58099

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2019
@Centril Centril mentioned this pull request Feb 3, 2019
Closed
78 tasks
@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Feb 4, 2019

r=me rollup with travis passing

@taiki-e taiki-e mentioned this pull request Feb 6, 2019
Merged
@Centril Centril force-pushed the libpanic_unwind-2018 branch from 19786bc to 6127151 Compare February 11, 2019 22:59
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor Author

Centril commented Feb 12, 2019

@oli-obk Here's a full dump with backtrace: https://gist.github.com/Centril/70b383fd22cb4e233a3cbcd6f750f600 ; it doesn't exactly happen at the same point, but hopefully it has enough detail...

@Centril Centril force-pushed the libpanic_unwind-2018 branch from 6127151 to c34e14e Compare February 12, 2019 23:07
@Centril
Copy link
Contributor Author

Centril commented Feb 12, 2019

@oli-obk Resolved the ICEs locally, but please double check that it was done in a way that doesn't have bad implications elsewhere.

oli-obk
oli-obk reviewed Feb 13, 2019
View reviewed changes
oli-obk
oli-obk reviewed Feb 13, 2019
View reviewed changes
@Centril Centril force-pushed the libpanic_unwind-2018 branch from c34e14e to 3657eaa Compare February 13, 2019 14:34
@oli-obk
Copy link
Contributor

oli-obk commented Feb 13, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 13, 2019

📌 Commit 3657eaa has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge of rust-lang#58110 - Centril:libpanic_unwind-2018, r=oli…
6a4f535 
…-obk

libpanic_unwind => 2018

Transitions `libpanic_unwind` to Rust 2018; cc rust-lang#58099

r? @oli-obk
@Centril Centril mentioned this pull request Feb 13, 2019
Closed
@Centril
Copy link
Contributor Author

Centril commented Feb 13, 2019

Failed in rollup (#58428 (comment)), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 13, 2019
@Centril Centril force-pushed the libpanic_unwind-2018 branch from 3657eaa to bb08499 Compare February 13, 2019 17:09
@Centril
Copy link
Contributor Author

Centril commented Feb 13, 2019

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Feb 13, 2019

📌 Commit bb08499 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 13, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
@Centril
Rollup merge of rust-lang#58110 - Centril:libpanic_unwind-2018, r=oli…
78c60bb 
…-obk

libpanic_unwind => 2018

Transitions `libpanic_unwind` to Rust 2018; cc rust-lang#58099

r? @oli-obk
@Centril Centril mentioned this pull request Feb 13, 2019
Merged
bors added a commit that referenced this pull request Feb 13, 2019
@bors
Auto merge of #58432 - Centril:rollup, r=Centril
4772dc8 
Rollup of 10 pull requests

Successful merges:

 - #58110 (libpanic_unwind => 2018)
 - #58167 (HirId-ify hir::BodyId)
 - #58202 (Ignore future deprecations in #[deprecated])
 - #58272 (Cut down on number formating code size)
 - #58276 (Improve the error messages for missing stability attributes)
 - #58354 (Fix ICE and invalid filenames in MIR printing code)
 - #58381 (Only suggest imports if not imported.)
 - #58386 (Fix #54242)
 - #58400 (Fix rustc_driver swallowing errors when compilation is stopped)
 - #58420 (target/uefi: clarify documentation)

Failed merges:

r? @ghost
@bors bors merged commit bb08499 into rust-lang:master Feb 14, 2019
@Centril Centril deleted the libpanic_unwind-2018 branch February 14, 2019 01:18
@Centril Centril mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Centril @rust-highfive @oli-obk @bors