Skip to content

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Nov 29, 2018

No description provided.

@rust-highfive
Copy link
Contributor

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2018
@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 29, 2018

@bors try

@bors
Copy link
Collaborator

bors commented Nov 29, 2018

⌛ Trying commit 4cce4ff with merge f980b36...

bors added a commit that referenced this pull request Nov 29, 2018
Add inline attributes and add unit to CommonTypes
@bors
Copy link
Collaborator

bors commented Nov 30, 2018

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 30, 2018

@rust-timer build f980b36

@rust-timer
Copy link
Collaborator

Please provide the full 40 character commit hash.

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 30, 2018

@rust-timer build f980b36

@rust-timer
Copy link
Collaborator

Success: Queued f980b36 with parent 3dde9e1, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit f980b36

@Zoxc
Copy link
Contributor Author

Zoxc commented Nov 30, 2018

Seems like a slight win.

r? @michaelwoerister

@michaelwoerister
Copy link
Member

@bors r+

Thanks @Zoxc! It's kinda sad that we still need these annotations although we have ThinLTO. Although I guess this is mostly because of using dylibs.

@bors
Copy link
Collaborator

bors commented Nov 30, 2018

📌 Commit 4cce4ff has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018
Add inline attributes and add unit to CommonTypes
kennytm added a commit to kennytm/rust that referenced this pull request Nov 30, 2018
Add inline attributes and add unit to CommonTypes
bors added a commit that referenced this pull request Nov 30, 2018
Rollup of 19 pull requests

Successful merges:

 - #55011 (Add libstd Cargo feature "panic_immediate_abort")
 - #55821 (Use sort_by_cached_key when the key function is not trivial/free)
 - #56014 (add test for issue #21335)
 - #56131 (Assorted tweaks)
 - #56214 (Implement chalk unification routines)
 - #56216 (Add TryFrom<&[T]> for [T; $N] where T: Copy)
 - #56268 (Reuse the `P` in `InvocationCollector::fold_{,opt_}expr`.)
 - #56324 (Use raw_entry for more efficient interning)
 - #56336 (Clean up and streamline the pretty-printer)
 - #56337 (Fix const_fn ICE with non-const function pointer)
 - #56339 (Remove not used option)
 - #56341 (Rename conversion util; remove duplicate util in librustc_codegen_llvm.)
 - #56349 (rustc 1.30.0's linker flavor inference is a non-backwards compat change to -Clinker)
 - #56355 (Add inline attributes and add unit to CommonTypes)
 - #56360 (Optimize local linkchecker program)
 - #56364 (Fix panic with outlives in existential type)
 - #56365 (Stabilize self_struct_ctor feature.)
 - #56367 (Moved some feature gate tests to correct location)
 - #56373 (Update books)
@bors bors merged commit 4cce4ff into rust-lang:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants