Skip to content

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Sep 21, 2017

This reduces the size of hir::Expr from 128 to 88 bytes (!) and shaves
200MB out of #36799.

This is a performance-sensitive PR so please don't roll it up.

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Sep 21, 2017

@bors p=1 r+

@bors
Copy link
Collaborator

bors commented Sep 21, 2017

📌 Commit c1ca233 has been approved by eddyb

@arielb1
Copy link
Contributor Author

arielb1 commented Sep 21, 2017

problem compiling rustdoc. Very done for today. Will fix on Sunday.

[00:36:02] error[E0609]: no field types on type &std::option::Option<syntax::ptr::P<rustc::hir::PathParameters>>

@bors r-

@shepmaster shepmaster added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 22, 2017
This reduces the size of hir::Expr from 128 to 88 bytes (!) and shaves
200MB out of rust-lang#36799.
@arielb1
Copy link
Contributor Author

arielb1 commented Sep 24, 2017

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Sep 24, 2017

📌 Commit e921b32 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Sep 24, 2017

⌛ Testing commit e921b32 with merge be962b0e0d7cd32f642cb3a304dbf9fc74e2900d...

@bors
Copy link
Collaborator

bors commented Sep 24, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

@bors retry

cc @alexcrichton -- possibly an issue with Cargo/crates.io?

[00:04:51] extracting /Users/travis/build/rust-lang/rust/build/cache/2017-08-29/rustc-beta-i686-apple-darwin.tar.gz

[00:04:52] downloading https://static.rust-lang.org/dist/2017-08-29/cargo-beta-i686-apple-darwin.tar.gz

[00:04:52] 
################################                                          44.6%
#######################################################                   76.5%
######################################################################## 100.0%

[00:04:55] extracting /Users/travis/build/rust-lang/rust/build/cache/2017-08-29/cargo-beta-i686-apple-darwin.tar.gz

[00:04:57]     Updating registry `https://github.com/rust-lang/crates.io-index`



No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

@bors
Copy link
Collaborator

bors commented Sep 24, 2017

⌛ Testing commit e921b32 with merge 48c1c54...

bors added a commit that referenced this pull request Sep 24, 2017
put empty generic lists behind a pointer

This reduces the size of hir::Expr from 128 to 88 bytes (!) and shaves
200MB out of #36799.

This is a performance-sensitive PR so please don't roll it up.

r? @eddyb
@bors
Copy link
Collaborator

bors commented Sep 25, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 48c1c54 to master...

@bors bors merged commit e921b32 into rust-lang:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants