Skip to content

Remove FusedIterator implementation of iter::Scan #42014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2017
Merged

Remove FusedIterator implementation of iter::Scan #42014

merged 1 commit into from
May 26, 2017

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented May 15, 2017

Fixes #41964.

This is a breaking change.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@tbu-
Copy link
Contributor Author

tbu- commented May 15, 2017

I'd like to know whether the current Scan behavior is the intended one.

@kennytm
Copy link
Member

kennytm commented May 15, 2017

There should be a test case?

@tbu-
Copy link
Contributor Author

tbu- commented May 15, 2017

Do you mean this PR or the scan function in general?

I don't think you need to test the absence of the FusedIterator implementation. If you mean the scan function in general: The test case does not exercise this behavior, it's still unclear after the doc example.

@kennytm
Copy link
Member

kennytm commented May 15, 2017

@tbu- Probably use the expected behavior of #41964 as the test case

@arielb1
Copy link
Contributor

arielb1 commented May 16, 2017

Thanks for the PR @tbu-! @brson (or someone else) will be reviewing your PR soon.

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2017
@Mark-Simulacrum
Copy link
Member

@brson This looks like it needs a review. Could you take a look?

@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 22, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented May 25, 2017

📌 Commit a7d91ef has been approved by alexcrichton

@alexcrichton alexcrichton added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2017
@bors
Copy link
Collaborator

bors commented May 25, 2017

⌛ Testing commit a7d91ef with merge 5280d66...

@bors
Copy link
Collaborator

bors commented May 25, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

@frewsxcv frewsxcv mentioned this pull request May 26, 2017
Closed
@bors
Copy link
Collaborator

bors commented May 26, 2017

⌛ Testing commit a7d91ef with merge 11d8b09...

@bors
Copy link
Collaborator

bors commented May 26, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented May 26, 2017

Emscripten timed out after 3 hours.

@Mark-Simulacrum
Copy link
Member

@bors retry

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 26, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42014 - tbu-:pr_scan_not_fused, r=alexcrichton
babc2a0 
Remove `FusedIterator` implementation of `iter::Scan`

Fixes rust-lang#41964.

This is a breaking change.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 26, 2017
Closed
@bors
Copy link
Collaborator

bors commented May 26, 2017

⌛ Testing commit a7d91ef with merge c732446...

bors added a commit that referenced this pull request May 26, 2017
@bors
Auto merge of #42014 - tbu-:pr_scan_not_fused, r=alexcrichton
c732446 
Remove `FusedIterator` implementation of `iter::Scan`

Fixes #41964.

This is a breaking change.
@bors
Copy link
Collaborator

bors commented May 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c732446 to master...

@bors bors merged commit a7d91ef into rust-lang:master May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brson brson

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tbu- @rust-highfive @kennytm @arielb1 @Mark-Simulacrum @alexcrichton @bors @brson @frewsxcv