Rollup of 5 pull requests #41226
Closed
Rollup of 5 pull requests #41226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
frewsxcv
commented
Apr 11, 2017
frewsxcv
commented
- Successful merges: Implement Manually Drop #40559, Fix block code headers parsing #41173, Convert HashMap to BTree in build-manifest #41202, Fixes incorrect formatting in array's documentation. #41204, Make sccache a bit quieter #41209
- Failed merges:
less intrinsics = better life
Implement Manually Drop As the RFC has been from approx a week in FCP without any major comments, I’m taking the opportunity to submit the PR early.
…ck-parsing, r=steveklabnik Fix block code headers parsing Fixes rust-lang#41167. r? @rust-lang/docs
Convert HashMap to BTree in build-manifest This is just for my peace of mind since it's important the output of this program be deterministic.
Fixes incorrect formatting in array's documentation. Changes - [`Clone`][clone] (only if `T: [Copy][copy]`) to - [`Clone`][clone] (only if `T: `[`Copy`](copy)) r? @steveklabnik
…richton Make sccache a bit quieter ...and remove the single mention of `SCCACHE_LOG_LEVEL` that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because [`RUST_LOG` takes priority](https://github.com/mozilla/sccache/blob/ec10cdb2ddeb3dde9891bea1fa095e504a60a28a/src/main.rs#L124-L128)). r? @frewsxcv
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit 5bda299 has been approved by |
|
⌛ Testing commit 5bda299 with merge 31f7ff3... |
|
💔 Test failed - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.