rustdoc: Fix string escaping in implementors js files #40451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generates HTML can contain quotes so we need to make sure they are escaped before inserting into the js files.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 19e0505 has been approved by |
|
⌛ Testing commit 19e0505 with merge a5483a7... |
bors
added a commit
that referenced
this pull request
Mar 13, 2017
rustdoc: Fix string escaping in implementors js files The generated HTML can contain quotes so we need to make sure they are escaped before inserting into the js files.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated HTML can contain quotes so we need to make sure they are
escaped before inserting into the js files.