Skip to content

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Feb 28, 2017

Restores similar behavior to make rules, where:

  • the step order was always the same, e.g. the testsuite order in make check
  • make check-stage1-{cfail,rpass} would always run cfail before rpass
    • ./x.py test--stage 1 src/test/{compile-fail,run-pass} is now equivalent

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 28, 2017

📌 Commit 4c8b39d has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Mar 3, 2017

⌛ Testing commit 4c8b39d with merge 2c6e0e4...

bors added a commit that referenced this pull request Mar 3, 2017
rustbuild: use deterministic step ordering and respect path order on the command-line.

Restores similar behavior to `make` rules, where:
* the step order was always the same, e.g. the testsuite order in `make check`
* `make check-stage1-{cfail,rpass}` would *always* run `cfail` before `rpass`
  * `./x.py test--stage 1 src/test/{compile-fail,run-pass}` is now equivalent

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Mar 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2c6e0e4 to master...

@bors bors merged commit 4c8b39d into rust-lang:master Mar 3, 2017
@eddyb eddyb deleted the order-in-rustbuild branch March 3, 2017 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants