Skip to content

Additional docs for Vec, String, and slice trait impls #39886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2017
Merged

Additional docs for Vec, String, and slice trait impls #39886

merged 1 commit into from
Feb 25, 2017

Conversation

mbrubeck
Copy link
Contributor

nagisa
nagisa reviewed Feb 16, 2017
View reviewed changes
src/libcollections/string.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“left-hand operand” may be a better way to name… operand on the left.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, also this sentence is supposed to be about the right-hand operand anyway.

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

looks great!

@bors
Copy link
Collaborator

bors commented Feb 21, 2017

📌 Commit b2ac1c9 has been approved by steveklabnik

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 22, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39886 - mbrubeck:doc-edit, r=steveklabnik
8f07320 
Additional docs for Vec, String, and slice trait impls

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 22, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 23, 2017
@frewsxcv
Rollup merge of rust-lang#39886 - mbrubeck:doc-edit, r=steveklabnik
2bd153e 
Additional docs for Vec, String, and slice trait impls

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Feb 23, 2017
Closed
bors added a commit that referenced this pull request Feb 23, 2017
@bors
Auto merge of #40045 - frewsxcv:rollup, r=frewsxcv
dd1c546 
Rollup of 11 pull requests

- Successful merges: #39859, #39886, #39892, #39903, #39914, #39918, #39988, #40010, #40027, #40030, #40035
- Failed merges:
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 23, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39886 - mbrubeck:doc-edit, r=steveklabnik
f8a642d 
Additional docs for Vec, String, and slice trait impls

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 23, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 23, 2017
@frewsxcv
Rollup merge of rust-lang#39886 - mbrubeck:doc-edit, r=steveklabnik
b8ccf59 
Additional docs for Vec, String, and slice trait impls

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Feb 23, 2017
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 24, 2017
@GuillaumeGomez
Rollup merge of rust-lang#39886 - mbrubeck:doc-edit, r=steveklabnik
3b10300 
Additional docs for Vec, String, and slice trait impls

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 24, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 24, 2017
@frewsxcv
Rollup merge of rust-lang#39886 - mbrubeck:doc-edit, r=steveklabnik
24e1dfb 
Additional docs for Vec, String, and slice trait impls

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Feb 24, 2017
Closed
bors added a commit that referenced this pull request Feb 24, 2017
@bors
Auto merge of #40080 - frewsxcv:rollup, r=frewsxcv
c9d3749 
Rollup of 17 pull requests

- Successful merges: #39777, #39815, #39845, #39886, #39892, #39903, #39905, #39914, #39927, #39940, #40010, #40030, #40048, #40050, #40052, #40060, #40071
- Failed merges:
bors added a commit that referenced this pull request Feb 25, 2017
@bors
Auto merge of #40072 - GuillaumeGomez:rollup, r=GuillaumeGomez
7932349 
Rollup of 11 pull requests

- Successful merges: #39777, #39815, #39845, #39886, #39940, #40010, #40030, #40048, #40050, #40052, #40071
- Failed merges:
@bors bors merged commit b2ac1c9 into rust-lang:master Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagisa nagisa nagisa left review comments

Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrubeck @steveklabnik @bors @nagisa