Skip to content

1.15 release notes #38966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2017
Merged

1.15 release notes #38966

merged 1 commit into from
Jan 21, 2017

Conversation

brson
Copy link
Contributor

@brson brson commented Jan 10, 2017 •
edited by steveklabnik
Loading

Rundered.

Lots of good stuff this release!

Perf graphs: https://goo.gl/KSVFvF, https://goo.gl/K98g8M, https://goo.gl/H1gSoz, https://goo.gl/yZBV2p, https://goo.gl/ltURbb. Not much change 😿

r? @steveklabnik

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 10, 2017
hanna-kruppe
hanna-kruppe reviewed Jan 10, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong issue/PR number. This refers to an issue titled "Using $crate with a proc macro"

bluss
bluss reviewed Jan 10, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this PR didn't actually change copy_from_slice (but changed impl Read for &[u8]), so that it special cases the single byte read case.

hanna-kruppe
hanna-kruppe reviewed Jan 10, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written this seems identical to the change four bullet points up. Granted, the PRs do basically the same thing, but throwing in a "more" somewhere would help — and indeed the linked PR is titled "Avoid more unnecessary ...".

petrochenkov
petrochenkov reviewed Jan 10, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already mentioned in 1.14 release notes.

est31
est31 reviewed Jan 10, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require [...] to take [...]

RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement*

RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note about the upcoming struct reorder by @camlorn ?

Copy link
Contributor

@bluss bluss Jan 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Peekable returns None it always does

This should be: if peekable peeks a None, it will return that same None in peek or next without querying the underlying iterator. Peekable is still not fused.

@brson
Copy link
Contributor Author

brson commented Jan 10, 2017

All comments addressed. Thanks for review.

@est31 re struct reordering, in these I don't mention any work in progress, only what's usable on stable.

est31
est31 reviewed Jan 10, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether this is accurate for the 1.15 release. PR #38401 was merged after 1.15 branched off. PR #37702 was only about a preview.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackpot51 @ticki is this okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, yeah. Maybe we should wait until the next release for this bullet.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 11, 2017

📌 Commit c6b73d2 has been approved by alexcrichton

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 11, 2017
durka
durka reviewed Jan 12, 2017
View reviewed changes
RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with the brace" sounds weird. "with curly braces"?

RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link target is right but the label is wrong (but it matches the link, so this doesn't actually matter).

RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link and the next one are swapped.

RELEASES.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just custom derive, not "including" custom derive, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the details I'm afraid, but I'll say that.

@mgattozzi mgattozzi mentioned this pull request Jan 13, 2017
Closed
@colin-kiegel colin-kiegel mentioned this pull request Jan 14, 2017
Closed
12 tasks
@brson
Copy link
Contributor Author

brson commented Jan 17, 2017

Thanks for the review @durka.

@brson
Copy link
Contributor Author

brson commented Jan 17, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 17, 2017

📌 Commit a0a4af1 has been approved by brson

@brson brson mentioned this pull request Jan 17, 2017
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 17, 2017
@alexcrichton alexcrichton mentioned this pull request Jan 19, 2017
Merged
@bors
Copy link
Collaborator

bors commented Jan 20, 2017

⌛ Testing commit a0a4af1 with merge a58c6f6...

@bors
Copy link
Collaborator

bors commented Jan 20, 2017

💔 Test failed - status-travis

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2017
@alexcrichton
Rollup merge of rust-lang#38966 - brson:relnotes, r=brson
18a39ed 
1.15 release notes

[Rundered](https://github.com/brson/rust/blob/relnotes/RELEASES.md#version-1150-2017-02-02).

Lots of good stuff this release!

Perf graphs: https://goo.gl/KSVFvF, https://goo.gl/K98g8M, https://goo.gl/H1gSoz, https://goo.gl/yZBV2p, https://goo.gl/ltURbb. Not much change 😿

r? @steveklabnik
@alexcrichton
Copy link
Member

alexcrichton commented Jan 20, 2017 via email

@bors
Copy link
Collaborator

bors commented Jan 20, 2017

⌛ Testing commit a0a4af1 with merge 8371487...

@alexcrichton
Copy link
Member

@bors: retry

  • prioritizing rollup

@bors
Copy link
Collaborator

bors commented Jan 20, 2017

⌛ Testing commit a0a4af1 with merge 5bc4c06...

@alexcrichton
Copy link
Member

@bors: retry

  • prioritizing rollup

@bors
Copy link
Collaborator

bors commented Jan 20, 2017

⌛ Testing commit a0a4af1 with merge 43f0020...

@alexcrichton
Copy link
Member

@bors: retry

  • prioritizing rollup

bors added a commit that referenced this pull request Jan 20, 2017
@bors
Auto merge of #39199 - alexcrichton:rollup, r=alexcrichton
b9b5138 
Rollup of 28 pull requests

- Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197
- Failed merges: #39060, #39145
@bors
Copy link
Collaborator

bors commented Jan 21, 2017

⌛ Testing commit a0a4af1 with merge 7b797c2...

@alexcrichton
Copy link
Member

@bors: retry

  • prioritizing rollup

bors added a commit that referenced this pull request Jan 21, 2017
@bors
Auto merge of #39199 - alexcrichton:rollup, r=alexcrichton
aedb49c 
Rollup of 28 pull requests

- Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197
- Failed merges: #39060, #39145
@bors
Copy link
Collaborator

bors commented Jan 21, 2017

⌛ Testing commit a0a4af1 with merge aedb49c...

@bors bors merged commit a0a4af1 into rust-lang:master Jan 21, 2017
@johnthagen
Copy link
Contributor

The link for "Rust supports the MSP430" seems to be formatted incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@est31 est31 est31 left review comments

+3 more reviewers

@durka durka durka left review comments

@hanna-kruppe hanna-kruppe hanna-kruppe left review comments

@bluss bluss bluss left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@steveklabnik steveklabnik

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@brson @alexcrichton @bors @johnthagen @durka @hanna-kruppe @bluss @petrochenkov @est31 @steveklabnik