Skip to content

Add missing links and examples for path modules and structs #38946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2017
Merged

Add missing links and examples for path modules and structs #38946

merged 1 commit into from
Jan 14, 2017

Conversation

GuillaumeGomez
Copy link
Member

@frewsxcv
Copy link
Contributor

frewsxcv commented Jan 9, 2017

Looks great! Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 9, 2017

📌 Commit 8c40a0a has been approved by frewsxcv

sanxiyn
sanxiyn suggested changes Jan 10, 2017
View reviewed changes
src/libstd/path.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Path] (akin to...) seems to be interpreted as a Markdown link, causing Travis failure in linkcheck.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well found!

@sanxiyn
Copy link
Contributor

sanxiyn commented Jan 10, 2017

@bors r-

@GuillaumeGomez
Copy link
Member Author

Updated.

frewsxcv
frewsxcv suggested changes Jan 10, 2017
View reviewed changes
src/libstd/path.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import: PathBuf

src/libstd/path.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import: PathBuf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(certainly github bug actually)

@GuillaumeGomez
Copy link
Member Author

Updated.

frewsxcv
frewsxcv reviewed Jan 11, 2017
View reviewed changes
src/libstd/path.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing import PathBuf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn, we'll never end it haha.

@GuillaumeGomez
Copy link
Member Author

Updated.

@frewsxcv
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 12, 2017

📌 Commit 28d1ac3 has been approved by frewsxcv

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 12, 2017
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2017
@GuillaumeGomez
Rollup merge of rust-lang#38946 - GuillaumeGomez:path_doc, r=frewsxcv
54535c5 
Add missing links and examples for path modules and structs

r? @frewsxcv
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 13, 2017
Merged
bors added a commit that referenced this pull request Jan 13, 2017
@bors
Auto merge of #39030 - GuillaumeGomez:rollup, r=GuillaumeGomez
7789881 
Rollup of 10 pull requests

- Successful merges: #38362, #38636, #38877, #38946, #38965, #38986, #38994, #38995, #39024, #39027
- Failed merges:
@bors bors merged commit 28d1ac3 into rust-lang:master Jan 14, 2017
@GuillaumeGomez GuillaumeGomez deleted the path_doc branch November 24, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@frewsxcv frewsxcv frewsxcv requested changes

@sanxiyn sanxiyn sanxiyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@frewsxcv frewsxcv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @frewsxcv @bors @sanxiyn