De-abstract std::sort:qsort3, which uses only the trait-based lt/eq. #3293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick_sort3 was converted from fn parameters to traits in d9cddde, but was still passing around closures over core::cmp::{eq,lt} internally, and LLVM doesn't and/or can't pick up that they're effectively constant. Reduces time spent to sort a large random ~[uint] by 16% in my testing.
|
Thanks! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
Keep leading colons for global paths
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Feb 17, 2024
Automatic Rustup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick_sort3 was converted from fn parameters to traits in d9cddde, but
was still passing around closures over core::cmp::{eq,lt} internally,
and LLVM doesn't and/or can't pick up that they're effectively constant.
Reduces time spent to sort a large random ~[uint] by 16% in my testing.