Fix a regression in import resolution #32097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an argument `allow_private_imports` to some methods.
jseyfried
force-pushed
the
fix_resolution_regression
branch
from
d7af276 to
162fa86
Compare
|
Thanks for the quick fix @jseyfried! |
|
r=me if comment is added |
|
@bors r=nikomatsakis |
|
📌 Commit 4dc4cae has been approved by |
|
Fixes #32106 |
bors
added a commit
that referenced
this pull request
Mar 10, 2016
…sakis Fix a regression in import resolution This fixes #32089 (caused by #31726) by deducing that name resolution has failed (as opposed to being determinate) in more cases. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #32089 (caused by #31726) by deducing that name resolution has failed (as opposed to being indeterminate) in more cases.
r? @nikomatsakis