Skip to content

Conversation

steveklabnik
Copy link
Contributor

Fixes #23196

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buff

@oli-obk
Copy link
Contributor

oli-obk commented Mar 23, 2015

also there's no mention that the number of bytes passed to consume must be <= to the number of bytes in the buffer returned by fill_buf

@steveklabnik
Copy link
Contributor Author

@oli-obk thanks! fixed. That naming convention is something I have yet to internalize, ugh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this follow the surrounding style of wrapping to 80 characters? Other than that r=me

@steveklabnik
Copy link
Contributor Author

@bors: r=alexcrichton rollup

@bors
Copy link
Collaborator

bors commented Mar 23, 2015

📌 Commit a5e1cbe has been approved by alexcrichton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BufReader .consume() confuses the Reader seek point when the buffer is empty

7 participants