Skip to content

Beef up docs for Box<T> #21516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2015
Merged

Beef up docs for Box<T> #21516

merged 1 commit into from
Jan 23, 2015

Conversation

steveklabnik
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

apasel422
apasel422 reviewed Jan 22, 2015
View reviewed changes
src/liballoc/boxed.rs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/provide/provides/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexcrichton
Copy link
Member

r=me with a few nits addressed

@steveklabnik
Copy link
Contributor Author

@bors: r=alexcrichton bbc0add rollup

@steveklabnik
Copy link
Contributor Author

I double checked them all locally. Thanks for the review 👍

@steveklabnik
Copy link
Contributor Author

@bors: r=alexcrichton 5a3bded rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 22, 2015
@steveklabnik
Rollup merge of rust-lang#21516 - steveklabnik:document_box, r=alexcr…
b994a3e 
…ichton
@steveklabnik steveklabnik mentioned this pull request Jan 22, 2015
Merged
bors added a commit that referenced this pull request Jan 23, 2015
@bors
Auto merge of #21530 - steveklabnik:rollup, r=steveklabnik
4874ca3 
- Successful merges: #21056, #21091, #21217, #21325, #21373, #21450, #21471, #21472, #21477, #21479, #21484, #21496, #21500, #21516, #21517
- Failed merges:
@bors bors merged commit 5a3bded into rust-lang:master Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brson brson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@steveklabnik @rust-highfive @alexcrichton @apasel422 @brson @bors