Improve example in the intro. #21020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
src/doc/intro.md
Outdated
There was a problem hiding this comment.
haha, my closures are people 😉
|
Addressed both nits. |
Thank you @bluss for the suggested implementation. Fixes rust-lang#20844
bors
added a commit
that referenced
this pull request
Jan 14, 2015
Improve example in the intro. Reviewed-by: alexcrichton
bors
referenced
this pull request
Jan 14, 2015
bors
added a commit
that referenced
this pull request
Jan 14, 2015
Improve example in the intro. Reviewed-by: alexcrichton
bors
referenced
this pull request
Jan 15, 2015
bors
added a commit
that referenced
this pull request
Jan 15, 2015
Improve example in the intro. Reviewed-by: alexcrichton
There was a problem hiding this comment.
Join guards are collected in this example to show explicitly how the things work, right? The code will behave in exactly the same way if we would just leave them out. Am I correct?
There was a problem hiding this comment.
Well, if you don't collect, the map won't do anything, as it's lazy. If you switch to a for, each guard drops out of scope on each iteration, so they end up executing serially anyway.
bors
added a commit
that referenced
this pull request
Jan 15, 2015
Improve example in the intro. Reviewed-by: alexcrichton
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 15, 2015
Thank you @bluss for the suggested implementation. Fixes rust-lang#20844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @bluss for the suggested implementation.
Fixes #20844