Add ICE regression test for issue #16218. #17062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathantypanski
force-pushed
the
generic-lifetime-trait-impl
branch
from
2bba56f to
344613a
Compare
This code used to produce an ICE on the definition of trait Bar with the following message: Type parameter out of range when substituting in region 'a (root type=fn(Self) -> 'astr) (space=FnSpace, index=0) Closes rust-lang#16218.
nathantypanski
force-pushed
the
generic-lifetime-trait-impl
branch
from
344613a to
d80729a
Compare
|
😍 |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 9, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…r=Veykril Temporarily disable unlinked file popup Not gonna look into this until the next release, so I'd rather disable it for the time being
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
…r=Veykril Temporarily disable unlinked file popup Not gonna look into this until the next release, so I'd rather disable it for the time being
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 11, 2024
fix: Improve hover text in unlinked file diagnostics Use full sentences, and mention how to disable the diagnostic if users are intentionally working on unowned files.  (Full disclosure: I've tested a rust-analyzer build in VS Code, but the pop-up logic is currently disabled due to rust-lang#17062, so I haven't tested that.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code used to produce an ICE on the definition of trait Bar
with the following message:
Type parameter out of range when substituting in region 'a (root
type=fn(Self) -> 'astr) (space=FnSpace, index=0)
Closes #16218.