librustc: Take the parameter space into account when combining type #15356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameters.
This can break code that mistakenly used type parameters in place of
`Self`. For example, this will break:
trait Foo {
fn bar<X>(u: X) -> Self {
u
}
}
Change this code to not contain a type error. For example:
trait Foo {
fn bar<X>(_: X) -> Self {
self
}
}
Closes rust-lang#15172.
[breaking-change]
bors
added a commit
that referenced
this pull request
Jul 4, 2014
parameters.
This can break code that mistakenly used type parameters in place of
`Self`. For example, this will break:
trait Foo {
fn bar<X>(u: X) -> Self {
u
}
}
Change this code to not contain a type error. For example:
trait Foo {
fn bar<X>(_: X) -> Self {
self
}
}
Closes #15172.
[breaking-change]
r? @alexcrichton
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
fix: Fix bad unwrap in eager_macro_recur Some logic changed so this path can be hit now with a missing token tree.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 18, 2025
…5356) Closes rust-lang/rust-clippy#15350 Follow up of rust-lang/rust-clippy#15064 changelog: [`never_loop`] add to remove `break` in nested loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameters.
This can break code that mistakenly used type parameters in place of
Self. For example, this will break:Change this code to not contain a type error. For example:
Closes #15172.
[breaking-change]
r? @alexcrichton