-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[rustdoc] Correctly handle should_panic
doctest attribute and fix --no-run
test flag on the 2024 edition
#147674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Let's see if it works like that, otherwise I'll add some |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
439161b
to
4cc12dc
Compare
This comment has been minimized.
This comment has been minimized.
4cc12dc
to
a7d6109
Compare
This comment has been minimized.
This comment has been minimized.
a7d6109
to
a47e09f
Compare
This comment has been minimized.
This comment has been minimized.
Ah right, forgot to fix std doc examples. |
Checking all previously failing CIs. @bors try jobs=armhf-gnu,test-various,x86_64-gnu-aux |
This comment has been minimized.
This comment has been minimized.
[rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition try-job: armhf-gnu try-job: test-various try-job: x86_64-gnu-aux
💔 Test for 0c093af failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
So the error comes from the fact that Let's try again. @bors try jobs=armhf-gnu,test-various,x86_64-gnu-aux |
This comment has been minimized.
This comment has been minimized.
[rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition try-job: armhf-gnu try-job: test-various try-job: x86_64-gnu-aux
💔 Test for 7103c01 failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8ab42d9
to
641f107
Compare
This comment has been minimized.
This comment has been minimized.
641f107
to
2c62952
Compare
@bors try jobs=armhf-gnu,test-various,x86_64-gnu-aux |
[rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition try-job: armhf-gnu try-job: test-various try-job: x86_64-gnu-aux
This comment has been minimized.
This comment has been minimized.
💔 Test for 38c3e03 failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
2c62952
to
0bffe4f
Compare
@bors try jobs=test-various |
[rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition try-job: test-various
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test for c5583f8 failed: CI. Failed jobs:
|
Not ready yet! Just more cleanups before my next attempt: if |
Fixes #143009.
Fixes #143858.
Supersedes #143900.
For
--no-run
, we forgot to check the "global" options in the 2024 edition, fixed in the first commit.For should_panic fix, the exit code check has been fixed.
r? @fmease