Skip to content

fix doc comments to be more standard #147016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

fix doc comments to be more standard #147016

merged 1 commit into from
Sep 27, 2025
+5 −23

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Sep 25, 2025

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

nnethercote
nnethercote approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@nnethercote nnethercote left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, these are weird.

View changes since this review

compiler/rustc_mir_build/src/builder/mod.rs Outdated
}

///////////////////////////////////////////////////////////////////////////
/// the main entry point for building MIR for a function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well make it a proper sentence.

Suggested change
/// the main entry point for building MIR for a function
/// The main entry point for building MIR for a function.

@nnethercote
Copy link
Contributor

r=me with the sentence fix mentioned above.

@bors delegate=hkBst

@bors
Copy link
Collaborator

bors commented Sep 25, 2025

✌️ @hkBst, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, please make that change, then do @bors r=@nnethercote

@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@hkBst
Copy link
Member Author

hkBst commented Sep 26, 2025 •
edited
Loading

@bors r=@nnethercote rollup

@bors
Copy link
Collaborator

bors commented Sep 26, 2025

📌 Commit fc703ec has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 26, 2025
@matthiaskrgr
Rollup merge of rust-lang#147016 - hkBst:whitespace-1, r=nnethercote
384afd3 
fix doc comments to be more standard
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 26, 2025
Closed
bors added a commit that referenced this pull request Sep 26, 2025
@bors
Auto merge of #147059 - matthiaskrgr:rollup-44mof1x, r=matthiaskrgr
0208156 
Rollup of 7 pull requests

Successful merges:

 - #145113 (resolve: Do not finalize shadowed bindings)
 - #146523 (Demote both armebv7r-none-* targets.)
 - #146778 (Use standard attribute logic for allocator shim)
 - #147016 (fix doc comments to be more standard)
 - #147027 (Add new `tyalias` intra-doc link disambiguator)
 - #147031 (mbe: Simplify check_redundant_vis_repetition)
 - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 26, 2025
@matthiaskrgr
Rollup merge of rust-lang#147016 - hkBst:whitespace-1, r=nnethercote
65e0a15 
fix doc comments to be more standard
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 26, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 26, 2025
@matthiaskrgr
Rollup merge of rust-lang#147016 - hkBst:whitespace-1, r=nnethercote
c1ee12c 
fix doc comments to be more standard
This was referenced Sep 26, 2025
Closed
Merged
bors added a commit that referenced this pull request Sep 26, 2025
@bors
Auto merge of #147074 - matthiaskrgr:rollup-sm3owsd, r=matthiaskrgr
ec37393 
Rollup of 10 pull requests

Successful merges:

 - #145113 (resolve: Do not finalize shadowed bindings)
 - #146523 (Demote both armebv7r-none-* targets.)
 - #146704 (port `#[debugger_visualizer]` to the new attribute system)
 - #146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu)
 - #146778 (Use standard attribute logic for allocator shim)
 - #146849 (Reduce some uses of `LegacyBang`)
 - #147016 (fix doc comments to be more standard)
 - #147027 (Add new `tyalias` intra-doc link disambiguator)
 - #147031 (mbe: Simplify check_redundant_vis_repetition)
 - #147058 (Ignore more failing ui tests for GCC backend)

Failed merges:

 - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 27, 2025
@bors
Auto merge of #147074 - matthiaskrgr:rollup-sm3owsd, r=matthiaskrgr
e131842 
Rollup of 10 pull requests

Successful merges:

 - #145113 (resolve: Do not finalize shadowed bindings)
 - #146523 (Demote both armebv7r-none-* targets.)
 - #146704 (port `#[debugger_visualizer]` to the new attribute system)
 - #146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu)
 - #146778 (Use standard attribute logic for allocator shim)
 - #146849 (Reduce some uses of `LegacyBang`)
 - #147016 (fix doc comments to be more standard)
 - #147027 (Add new `tyalias` intra-doc link disambiguator)
 - #147031 (mbe: Simplify check_redundant_vis_repetition)
 - #147058 (Ignore more failing ui tests for GCC backend)

Failed merges:

 - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e504c10 into rust-lang:master Sep 27, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 27, 2025
rust-timer added a commit that referenced this pull request Sep 27, 2025
@rust-timer
Unrolled build for #147016
e511126 
Rollup merge of #147016 - hkBst:whitespace-1, r=nnethercote

fix doc comments to be more standard
@hkBst hkBst deleted the whitespace-1 branch September 27, 2025 05:54
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Sep 29, 2025
@bors
Auto merge of #147074 - matthiaskrgr:rollup-sm3owsd, r=matthiaskrgr
0d1311a 
Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#145113 (resolve: Do not finalize shadowed bindings)
 - rust-lang/rust#146523 (Demote both armebv7r-none-* targets.)
 - rust-lang/rust#146704 (port `#[debugger_visualizer]` to the new attribute system)
 - rust-lang/rust#146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu)
 - rust-lang/rust#146778 (Use standard attribute logic for allocator shim)
 - rust-lang/rust#146849 (Reduce some uses of `LegacyBang`)
 - rust-lang/rust#147016 (fix doc comments to be more standard)
 - rust-lang/rust#147027 (Add new `tyalias` intra-doc link disambiguator)
 - rust-lang/rust#147031 (mbe: Simplify check_redundant_vis_repetition)
 - rust-lang/rust#147058 (Ignore more failing ui tests for GCC backend)

Failed merges:

 - rust-lang/rust#147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercote nnethercote nnethercote approved these changes

Assignees

@nnethercote nnethercote

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@hkBst @rustbot @nnethercote @bors