add regression test #146918
add regression test #146918
Conversation
rustbot
added
S-waiting-on-review
|
rustbot has assigned @jdonszelmann. Use |
rustbot
added
the
stable-nominated
|
cc @rust-lang/infra why did |
lcnr
removed
the
stable-nominated
|
Couldn't this be due to #131960 being a regression from stable to stable? However, it is not even mentioned as being closed by this PR. |
lcnr
force-pushed
the
add-regression-test
branch
from
e298557 to
d8369eb
Compare
lcnr
force-pushed
the
add-regression-test
branch
from
d8369eb to
465e373
Compare
|
It's configured to stable-nominate all T-compiler PRs that close issues that are regressions from stable to stable. https://github.com/rust-lang/rust/blob/master/triagebot.toml#L64-L67 The PR description says "closes #128887" |
What exactly do you mean? #131960 is a regression from stable due to MIR inlining which still exists. We've made it a harder to hit in #129714 but it still triggers for some crates, so we're keeping #131960 open. #128887 also tracked a separately issue which has since been fully fixed in #129073.
Ah, that makes a lot of sense, thanks 😅 👍 |
|
sorry for the delay, looks good and the other issues seem to track remaining issues. @bors r+ |
bors
added
S-waiting-on-bors
Rollup of 11 pull requests Successful merges: - #146918 (add regression test) - #146980 (simplify setup_constraining_predicates, and note it is potentially cubic) - #147170 (compiletest: Pass around `DirectiveLine` instead of bare strings) - #147180 (add tests) - #147188 (Remove usage of `compiletest-use-stage0-libtest` from CI) - #147189 (Replace `rustc_span::Span` with a stripped down version for librustdoc's highlighter) - #147199 (remove outdated comment in (inner) `InferCtxt`) - #147200 (Fix autodiff empty ret regression) - #147209 (Remove `no-remap-src-base` from tests) - #147213 (Fix broken STD build for ESP-IDF) - #147217 (Don't create a top-level `true` directory when running UI tests) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #146918 - lcnr:add-regression-test, r=jdonszelmann add regression test closes #128887 the errors in that issue are due to two separate issues: - MIR inlining causing the trait solver to hit the recursion limit (partially fixed in #129714) - using subtyping in method selection for paths (fixed in #129073) We moved any remaining issues due to MIR inlining into #131960, but keeping #128887 open as well seems unhelpful and confusing.
closes #128887
the errors in that issue are due to two separate issues:
Mode::Path#129073)We moved any remaining issues due to MIR inlining into #131960, but keeping #128887 open as well seems unhelpful and confusing.