Skip to content

Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples #146887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples #146887

merged 1 commit into from
Sep 22, 2025

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Sep 22, 2025

#93109 removed the use of APIs enabled by this feature in these examples, but the #![feature] attributes ware not removed.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet
Copy link
Member

joboet commented Sep 22, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 22, 2025

📌 Commit 823337a has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2025
@joboet joboet assigned joboet and unassigned tgross35 Sep 22, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 22, 2025
Merged
bors added a commit that referenced this pull request Sep 22, 2025
@bors
Auto merge of #146892 - GuillaumeGomez:rollup-fa7lp0n, r=GuillaumeGomez
f6092f2 
Rollup of 5 pull requests

Successful merges:

 - #146795 (Enable `limit_rdylib_exports` on wasm targets)
 - #146828 (fix a crash in rustdoc merge finalize without input file)
 - #146848 (Add x86_64-unknown-motor (Motor OS) tier 3 target)
 - #146884 (Fix modification check of `rustdoc-json-types`)
 - #146887 (Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9814d08 into rust-lang:master Sep 22, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 22, 2025
@rust-timer
Unrolled build for #146887
ae9d33f 
Rollup merge of #146887 - taiki-e:rc-doc-feature, r=joboet

Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples

#93109 removed the use of APIs enabled by this feature in these examples, but the `#![feature]` attributes ware not removed.
@rustbot rustbot added this to the 1.92.0 milestone Sep 22, 2025
@taiki-e taiki-e deleted the rc-doc-feature branch September 23, 2025 02:42
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 23, 2025
@bors
Auto merge of #146892 - GuillaumeGomez:rollup-fa7lp0n, r=GuillaumeGomez
f843cd4 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#146795 (Enable `limit_rdylib_exports` on wasm targets)
 - rust-lang/rust#146828 (fix a crash in rustdoc merge finalize without input file)
 - rust-lang/rust#146848 (Add x86_64-unknown-motor (Motor OS) tier 3 target)
 - rust-lang/rust#146884 (Fix modification check of `rustdoc-json-types`)
 - rust-lang/rust#146887 (Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples)

r? `@ghost`
`@rustbot` modify labels: rollup
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@GuillaumeGomez @Muscraft
Rollup merge of rust-lang#146887 - taiki-e:rc-doc-feature, r=joboet
e56ad51 
Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples

rust-lang#93109 removed the use of APIs enabled by this feature in these examples, but the `#![feature]` attributes ware not removed.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@bors @Muscraft
Auto merge of rust-lang#146892 - GuillaumeGomez:rollup-fa7lp0n, r=Gui…
eec4dd9 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#146795 (Enable `limit_rdylib_exports` on wasm targets)
 - rust-lang#146828 (fix a crash in rustdoc merge finalize without input file)
 - rust-lang#146848 (Add x86_64-unknown-motor (Motor OS) tier 3 target)
 - rust-lang#146884 (Fix modification check of `rustdoc-json-types`)
 - rust-lang#146887 (Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/compiler-builtins that referenced this pull request Sep 25, 2025
@bors
Auto merge of #146892 - GuillaumeGomez:rollup-fa7lp0n, r=GuillaumeGomez
477d945 
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#146795 (Enable `limit_rdylib_exports` on wasm targets)
 - rust-lang/rust#146828 (fix a crash in rustdoc merge finalize without input file)
 - rust-lang/rust#146848 (Add x86_64-unknown-motor (Motor OS) tier 3 target)
 - rust-lang/rust#146884 (Fix modification check of `rustdoc-json-types`)
 - rust-lang/rust#146887 (Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@GuillaumeGomez
Rollup merge of rust-lang#146887 - taiki-e:rc-doc-feature, r=joboet
aae4645 
Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples

rust-lang#93109 removed the use of APIs enabled by this feature in these examples, but the `#![feature]` attributes ware not removed.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@bors
Auto merge of rust-lang#146892 - GuillaumeGomez:rollup-fa7lp0n, r=Gui…
7173fae 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#146795 (Enable `limit_rdylib_exports` on wasm targets)
 - rust-lang#146828 (fix a crash in rustdoc merge finalize without input file)
 - rust-lang#146848 (Add x86_64-unknown-motor (Motor OS) tier 3 target)
 - rust-lang#146884 (Fix modification check of `rustdoc-json-types`)
 - rust-lang#146887 (Remove unused #![feature(get_mut_unchecked)] in Rc and Arc examples)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@taiki-e @rustbot @joboet @bors @tgross35