Bump bootstrap compiler to 1.91 beta #146636

Mark-Simulacrum · 2025-09-16T12:19:13Z

https://forge.rust-lang.org/release/process.html#default-branch-bootstrap-update-tuesday

rustbot · 2025-09-16T12:19:16Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

rustbot · 2025-09-16T12:19:18Z

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

src/tools/lint-docs/src/lib.rs

compiler/rustc_lint_defs/src/builtin.rs

Kobzol · 2025-09-16T22:01:38Z

Feel free to remove the failing bootstrap test (detect_src_and_out), we are on our way to remove it anyway in a different PR.

rustbot · 2025-09-16T22:36:10Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Mark-Simulacrum · 2025-09-17T20:30:11Z

OK, should be ready for review.

jieyouxu

Thanks, mostly looks good, just 3 nits

View changes since this review

compiler/rustc_const_eval/src/lib.rs

src/bootstrap/src/core/sanity.rs

jieyouxu · 2025-09-19T01:02:24Z

@rustbot author

bors · 2025-09-22T22:16:41Z

☔ The latest upstream changes (presumably #146892) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu

Thanks

View changes since this review

jieyouxu · 2025-09-27T03:31:27Z

src/bootstrap/src/core/sanity.rs

    // just a dummy comment so the list doesn't get onelined
-    "aarch64_be-unknown-hermit",
-    "aarch64_be-unknown-none-softfloat",
    "x86_64-unknown-motor",


N.B. for myself: this was added 5 days ago.

jieyouxu · 2025-09-27T03:32:48Z

Giving this a higher p since it's been some time.
@bors r+ rollup=never p=10

bors · 2025-09-27T03:32:50Z

📌 Commit 54669d7 has been approved by jieyouxu

It is now in the queue for this repository.

bors · 2025-09-27T03:50:07Z

⌛ Testing commit 54669d7 with merge 959b450...

bors · 2025-09-27T06:56:53Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 959b450 to master...

github-actions · 2025-09-27T07:00:22Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e131842 (parent) -> 959b450 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 959b450747f81e720be3a829665dd30e553e7fd7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

tidy: 182.2s -> 227.0s (24.6%)
x86_64-gnu-llvm-20: 2560.3s -> 2979.2s (16.4%)
dist-apple-various: 4009.5s -> 3508.7s (-12.5%)
dist-i686-mingw: 8601.2s -> 9613.2s (11.8%)
aarch64-msvc-2: 4654.0s -> 5194.7s (11.6%)
x86_64-gnu-llvm-20-1: 3190.0s -> 3504.1s (9.8%)
dist-ohos-armv7: 4465.6s -> 4093.9s (-8.3%)
aarch64-apple: 5822.6s -> 6284.6s (7.9%)
x86_64-gnu-llvm-20-3: 6826.4s -> 6343.8s (-7.1%)
dist-x86_64-netbsd: 4906.2s -> 4560.3s (-7.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-27T08:07:52Z

Finished benchmarking commit (959b450): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.04s -> 472.089s (0.44%)
Artifact size: 388.10 MiB -> 388.09 MiB (-0.00%)

compiletest: Use `PanicHookInfo::payload_as_str` now that it's stable in beta Nice little FIXME cleanup after the bootstrap beta bump to 1.91 in rust-lang#146636. r? jieyouxu

Rollup merge of #147086 - Zalathar:payload, r=jieyouxu compiletest: Use `PanicHookInfo::payload_as_str` now that it's stable in beta Nice little FIXME cleanup after the bootstrap beta bump to 1.91 in #146636. r? jieyouxu

…eyouxu Bump bootstrap compiler to 1.91 beta https://forge.rust-lang.org/release/process.html#default-branch-bootstrap-update-tuesday

rustbot assigned scottmcm Sep 16, 2025

This comment has been minimized.

Sign in to view

Mark-Simulacrum commented Sep 16, 2025

View reviewed changes

src/tools/lint-docs/src/lib.rs Outdated Show resolved Hide resolved

samueltardieu reviewed Sep 16, 2025

View reviewed changes

src/tools/lint-docs/src/lib.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

madsmtm mentioned this pull request Sep 16, 2025

Re-enable assertions on macOS alt builds #146513

Merged

madsmtm reviewed Sep 16, 2025

View reviewed changes

compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved

Mark-Simulacrum force-pushed the bootstrap-bump branch 2 times, most recently from ce155f3 to ef7c00a Compare September 16, 2025 22:36

jieyouxu self-assigned this Sep 18, 2025

jieyouxu approved these changes Sep 19, 2025

View reviewed changes

compiler/rustc_const_eval/src/lib.rs Show resolved Hide resolved

compiler/rustc_const_eval/src/lib.rs Show resolved Hide resolved

src/bootstrap/src/core/sanity.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2025

jieyouxu mentioned this pull request Sep 23, 2025

compiletest: Remove old-output-capture and become a stage0 bootstrap tool #146929

Merged

Update CURRENT_RUSTC_VERSION post-bump

4e9716f

jieyouxu approved these changes Sep 27, 2025

View reviewed changes

jieyouxu unassigned scottmcm Sep 27, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2025

bors merged commit 959b450 into rust-lang:master Sep 27, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Sep 27, 2025

This was referenced Sep 27, 2025

Implement RFC 3631: add rustdoc doc_cfg features #138907

Merged

Include additional hashes in src/stage0 #142139

Merged

Stabilize fmt::from_fn #145915

Open

This was referenced Sep 27, 2025

Stabilize debug_closure_helpers #146099

Open

Implement raw-dylib on Mach-O #146357

Draft

mbe: Macro fragment fields #147025

Draft

Fix tracking issue number for feature(macro_attr) #147066

Merged

Zalathar mentioned this pull request Sep 27, 2025

compiletest: Use PanicHookInfo::payload_as_str now that it's stable in beta #147086

Merged

cyrgani mentioned this pull request Sep 27, 2025

remove duplicated columns from rustc_error_code::error_codes! #146584

Open

DJMcNab mentioned this pull request Sep 28, 2025

Fix removed version numbers of doc_auto_cfg and doc_cfg_hide #147123

Merged

heiher mentioned this pull request Sep 28, 2025

Reland "Add LSX accelerated implementation for source file analysis" #147113

Merged

github-actions bot mentioned this pull request Sep 29, 2025

Toolchain upgrade to nightly-2025-10-09 flux-rs/flux#1271

Merged

Bump bootstrap compiler to 1.91 beta #146636

Bump bootstrap compiler to 1.91 beta #146636

Uh oh!

Conversation

Mark-Simulacrum commented Sep 16, 2025

Uh oh!

rustbot commented Sep 16, 2025

Uh oh!

rustbot commented Sep 16, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Kobzol commented Sep 16, 2025

Uh oh!

rustbot commented Sep 16, 2025

Uh oh!

Mark-Simulacrum commented Sep 17, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Sep 19, 2025

Uh oh!

bors commented Sep 22, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Sep 27, 2025

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Sep 27, 2025

Uh oh!

bors commented Sep 27, 2025

Uh oh!

bors commented Sep 27, 2025

Uh oh!

bors commented Sep 27, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 27, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 27, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading