Skip to content

triagebot: warn about #[rustc_intrinsic_const_stable_indirect] #146365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

triagebot: warn about #[rustc_intrinsic_const_stable_indirect] #146365

merged 1 commit into from
Sep 9, 2025

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 9, 2025

Also make the warnings a bit more noticeable by adding a ⚠️.

@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

#[miri::intrinsic_fallback_is_spec] must only be used if the function actively checks for all UB cases,
and explores the possible non-determinism of the intrinsic.

cc @rust-lang/miri

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

#[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

cc @rust-lang/wg-const-eval

@RalfJung RalfJung force-pushed the triagebot-rustc_intrinsic_const_stable_indirect branch from d95710c to c63e034 Compare September 9, 2025 06:34
@jieyouxu
Copy link
Member

jieyouxu commented Sep 9, 2025

(Feel free to self-approve trivial triagebot config changes)
r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 9, 2025

📌 Commit c63e034 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned Mark-Simulacrum Sep 9, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 9, 2025
Merged
bors added a commit that referenced this pull request Sep 9, 2025
@bors
Auto merge of #146375 - matthiaskrgr:rollup-utik9zj, r=matthiaskrgr
7ad23f4 
Rollup of 6 pull requests

Successful merges:

 - #145463 (Reject invalid literal suffixes in tuple indexing, tuple struct indexing, and struct field name position)
 - #145929 (fix APITIT being treated as a normal generic parameter in suggestions)
 - #146001 (Update getopts to remove unicode-width dependency)
 - #146365 (triagebot: warn about #[rustc_intrinsic_const_stable_indirect])
 - #146366 (add approx_delta to all gamma tests)
 - #146373 (fix comments about trait solver cycle heads)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit af4cece into rust-lang:master Sep 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 9, 2025
rust-timer added a commit that referenced this pull request Sep 9, 2025
@rust-timer
Unrolled build for #146365
9843200 
Rollup merge of #146365 - RalfJung:triagebot-rustc_intrinsic_const_stable_indirect, r=jieyouxu

triagebot: warn about #[rustc_intrinsic_const_stable_indirect]

Also make the warnings a bit more noticeable by adding a ⚠️.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 9, 2025
Closed
@Zalathar
Copy link
Contributor

Bors, this has already been merged.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 10, 2025
@RalfJung RalfJung deleted the triagebot-rustc_intrinsic_const_stable_indirect branch September 10, 2025 09:16
@github-actions github-actions bot mentioned this pull request Sep 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @jieyouxu @bors @Zalathar @Mark-Simulacrum