-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Intrinsic overflow checks perf trial #146288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to constck cc @fee1-dead The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr Some changes occurred to the CTFE machinery Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in src/tools/clippy cc @rust-lang/clippy This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @vakaras |
This comment has been minimized.
This comment has been minimized.
3448d96
to
0cae867
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #146683) made this pull request unmergeable. Please resolve the merge conflicts. |
0cae867
to
ddee69b
Compare
This comment has been minimized.
This comment has been minimized.
check overflow after yielding MAX value `0_u8..` will yield `255` and only panic on the subsequent `next()`
ddee69b
to
47e50ab
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Based on #128666
This PR exists to test the perf effects of adding a new intrinsic, like
ub_checks
, for overflow checks. Tests are expected to fail.