Skip to content

Revert "fix(debuginfo): disable overflow check for recursive non-enum types" #145979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

Revert "fix(debuginfo): disable overflow check for recursive non-enum types" #145979

merged 1 commit into from
Aug 29, 2025

Conversation

wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Aug 29, 2025 •
edited by rustbot
Loading

This reverts commit 49eda8e.

Discussed during the T-compiler triage meeting with the decision to revert #144407 instead of attempting a forward fix.

@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@wesleywiser wesleywiser added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 29, 2025
jieyouxu
jieyouxu approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me once PR CI is green

View changes since this review

@jieyouxu jieyouxu assigned jieyouxu and unassigned SparrowLii Aug 29, 2025
@jieyouxu jieyouxu changed the title Revert "fix(debuginfo): disable overflow check for" Revert "fix(debuginfo): disable overflow check for recursive non-enum types" Aug 29, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Aug 29, 2025 •
edited
Loading

I'm going to preemptively reopen #143241. EDIT: wait no, this reverts on beta only, the follow-up changes would still be present on nightly.

@jieyouxu
Copy link
Member

Queue is reasonably light so
@bors p=5 (beta revert)

@jieyouxu
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 29, 2025

📌 Commit 161e29d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2025
@bors
Copy link
Collaborator

bors commented Aug 29, 2025

⌛ Testing commit 161e29d with merge fb918ce...

@bors
Copy link
Collaborator

bors commented Aug 29, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing fb918ce to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2025
@bors bors merged commit fb918ce into rust-lang:beta Aug 29, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wesleywiser @rustbot @jieyouxu @bors @SparrowLii