Rename impl_of_method and trait_of_item #144377

camsteffen · 2025-07-23T20:35:39Z

This PR used to tweak the implementation of impl_of_method, but that introduced a perf regression.

Rename impl_of_method and trait_of_item to impl_of_assoc and trait_of_assoc respectively. This reflects how the two functions are closely related. And it reflects the behavior more accurately as the functions check whether the input is an associated item.

rustbot · 2025-07-23T20:35:44Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kobzol · 2025-07-24T08:24:37Z

@bors try @rust-timer queue

rust-bors · 2025-07-24T08:24:41Z

⌛ Trying commit e019fd7 with merge bf4a373…

To cancel the try build, run the command @bors try cancel.

Simplify impl_of_method

fee1-dead · 2025-07-24T09:24:13Z

this should really be renamed to opt_impl_parent or impl_of_assoc instead.

r=me after good/neutral perf, rename can be in followup

rust-bors · 2025-07-24T10:39:06Z

☀️ Try build successful (CI)
Build commit: bf4a373 (bf4a373133f6ff486e137e70291a5d9e95fe7fae, parent: 3c30dbbe31bfbf6029f4534170165ba573ff0fd1)

rust-timer · 2025-07-24T11:48:07Z

Finished benchmarking commit (bf4a373): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 0.7%]	17
Regressions ❌ (secondary)	0.3%	[0.0%, 0.6%]	24
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.1%, 0.7%]	17

Max RSS (memory usage)

Results (primary -1.4%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-2.3%, -0.9%]	4
Improvements ✅ (secondary)	-1.8%	[-2.8%, -1.2%]	4
All ❌✅ (primary)	-1.4%	[-2.3%, -0.9%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.586s -> 466.337s (-0.48%)
Artifact size: 374.68 MiB -> 374.63 MiB (-0.01%)

camsteffen · 2025-07-24T12:11:42Z

Hmm that doesn't look like a win. I guess it's because the non assoc input case is now parent+def_kind where it used to be just def_kind. There could be an opportunity to split out a panicking version but I'm not sure if that's worth it either.

Agreed about the rename.

fee1-dead · 2025-07-24T15:28:28Z

Well, i'd be happy to r+ if you repurpose this PR so that it's just the renaming :)

rustbot · 2025-07-25T00:10:30Z

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in need_type_info.rs

cc @lcnr

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

HIR ty lowering was modified

cc @fmease

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

camsteffen · 2025-07-25T00:13:26Z

Oooof that's a lot of tags 🫣

fee1-dead · 2025-07-25T08:06:41Z

still potentially perf sensitive, so

@bors2 try @rust-timer queue

rust-bors · 2025-07-25T08:06:45Z

⌛ Trying commit 448868a with merge 0ed9f77…

To cancel the try build, run the command @bors try cancel.

Rename impl_of_method and trait_of_item

fee1-dead · 2025-07-28T14:40:54Z

r=me after rebase

@bors delegate+

bors · 2025-07-28T14:40:56Z

✌️ @camsteffen, you can now approve this pull request!

If @fee1-dead told you to "r=me" after making some further change, please make that change, then do @bors r=@fee1-dead

This is dead code.

camsteffen · 2025-07-28T14:58:17Z

@bors r=fee1-dead

bors · 2025-07-28T14:58:19Z

📌 Commit cdcfdd1 has been approved by fee1-dead

It is now in the queue for this repository.

bors · 2025-07-28T16:38:18Z

⌛ Testing commit cdcfdd1 with merge e3514bd...

bors · 2025-07-28T19:38:36Z

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing e3514bd to master...

github-actions · 2025-07-28T19:42:04Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9ba00e0 (parent) -> e3514bd (this PR)

Test differences

Show 10 test diffs

10 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e3514bde96d2d13586337a48db77fa64b850d249 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 6510.5s -> 8257.3s (26.8%)
dist-aarch64-apple: 6553.4s -> 5064.3s (-22.7%)
dist-apple-various: 7336.1s -> 5799.0s (-21.0%)
aarch64-apple: 5219.9s -> 6249.7s (19.7%)
dist-x86_64-apple: 11486.0s -> 9607.8s (-16.4%)
aarch64-gnu-llvm-19-2: 2285.8s -> 2647.3s (15.8%)
pr-check-2: 2267.7s -> 2617.6s (15.4%)
x86_64-apple-2: 4118.0s -> 4752.7s (15.4%)
x86_64-gnu-llvm-19: 2450.6s -> 2809.7s (14.7%)
x86_64-rust-for-linux: 2624.6s -> 2956.9s (12.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-28T20:50:06Z

Finished benchmarking commit (e3514bd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.3%	[3.3%, 3.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.5%, -2.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-2.5%, 3.3%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.487s -> 468.526s (0.01%)
Artifact size: 376.81 MiB -> 376.81 MiB (0.00%)

Relevant upstream PRs: - rust-lang/rust#144389 (MIR-build: No longer emit assumes in enum-as casting) - rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) - rust-lang/rust#144377 (Rename impl_of_method and trait_of_item) Resolves: model-checking#4246

Relevant upstream PRs: - rust-lang/rust#144389 (MIR-build: No longer emit assumes in enum-as casting) - rust-lang/rust#144392 (rustc_public: Remove movability from `RigidTy/AggregateKind::Coroutine`) - rust-lang/rust#144377 (Rename impl_of_method and trait_of_item) Resolves: #4246 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Signed-off-by: sagudev <[email protected]>

rustbot assigned fee1-dead Jul 23, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 23, 2025

This comment has been minimized.

Sign in to view

camsteffen force-pushed the simplify-impl-of-method branch from 230e8b9 to e019fd7 Compare July 23, 2025 21:04

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jul 24, 2025

Auto merge of #144377 - camsteffen:simplify-impl-of-method, r=<try>

bf4a373

Simplify impl_of_method

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 24, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 24, 2025

camsteffen force-pushed the simplify-impl-of-method branch from e019fd7 to 448868a Compare July 25, 2025 00:10

rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations T-clippy Relevant to the Clippy team. labels Jul 25, 2025

camsteffen changed the title ~~Simplify impl_of_method~~ Rename impl_of_method and trait_of_item Jul 25, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jul 25, 2025

Auto merge of #144377 - camsteffen:simplify-impl-of-method, r=<try>

0ed9f77

Rename impl_of_method and trait_of_item

camsteffen added 5 commits July 28, 2025 09:53

Remove TraitAlias from trait_of_item

96aca2b

This is dead code.

Introduce assoc_parent

0d7abc8

Rename trait_of_item -> trait_of_assoc

172af03

Rename impl_of_method -> impl_of_assoc

b43164c

Tweak docs

cdcfdd1

camsteffen force-pushed the simplify-impl-of-method branch from f257f7b to cdcfdd1 Compare July 28, 2025 14:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2025

bors merged commit e3514bd into rust-lang:master Jul 28, 2025
11 checks passed

rustbot added this to the 1.90.0 milestone Jul 28, 2025

bors mentioned this pull request Jul 28, 2025

GCI: Don't evaluate the initializer of free const items that have trivially unsatisfied predicates #142293

Closed

bors mentioned this pull request Jul 28, 2025

coverage: Treat #[automatically_derived] as #[coverage(off)] #144560

Merged

tautschnig mentioned this pull request Jul 29, 2025

Upgrade Rust toolchain to 2025-07-29 model-checking/kani#4247

Merged

sagudev added a commit to sagudev/servo that referenced this pull request Sep 24, 2025

https://github.com/rust-lang/rust/pull/144377

e872d8b

Signed-off-by: sagudev <[email protected]>

sagudev added a commit to sagudev/servo that referenced this pull request Sep 25, 2025

https://github.com/rust-lang/rust/pull/144377

2125ed8

Signed-off-by: sagudev <[email protected]>

camsteffen deleted the simplify-impl-of-method branch October 9, 2025 02:41

Rename impl_of_method and trait_of_item #144377

Rename impl_of_method and trait_of_item #144377

Uh oh!

Conversation

camsteffen commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 23, 2025

Uh oh!

This comment has been minimized.

Kobzol commented Jul 24, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 24, 2025

Uh oh!

fee1-dead commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Jul 24, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jul 24, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

camsteffen commented Jul 24, 2025

Uh oh!

fee1-dead commented Jul 24, 2025

Uh oh!

rustbot commented Jul 25, 2025

Uh oh!

camsteffen commented Jul 25, 2025

Uh oh!

fee1-dead commented Jul 25, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jul 25, 2025

Uh oh!

fee1-dead commented Jul 28, 2025

Uh oh!

bors commented Jul 28, 2025

Uh oh!

camsteffen commented Jul 28, 2025

Uh oh!

bors commented Jul 28, 2025

Uh oh!

bors commented Jul 28, 2025

Uh oh!

bors commented Jul 28, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 28, 2025

Overall result: no relevant changes - no action needed

Uh oh!

Uh oh!

camsteffen commented Jul 23, 2025 •

edited

Loading

fee1-dead commented Jul 24, 2025 •

edited

Loading