Skip to content

Conversation

LimpSquid
Copy link
Contributor

Tracking Issue

#142748

ACP

rust-lang/libs-team#606

@rustbot
Copy link
Collaborator

rustbot commented Jun 19, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 19, 2025
@scottmcm
Copy link
Member

scottmcm commented Jul 3, 2025

Unstable and looks like it's aligned with rust-lang/libs-team#606 (comment), so sounds good!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 3, 2025

📌 Commit 19352e9 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
bors added a commit that referenced this pull request Jul 4, 2025
Rollup of 11 pull requests

Successful merges:

 - #142749 (Add methods for converting bool to `Result<(), E>`)
 - #143288 (Fix `x clean` with a fifo)
 - #143307 (Fast path nitpicks)
 - #143346 (update coherence example)
 - #143356 (use unsigned_abs instead of `abs` on signed int to silence clippy)
 - #143370 (remove redundant #[must_use])
 - #143378 (simplify receivers for some array method calls)
 - #143380 (Replace kw_span by full span for generic const parameters.)
 - #143381 (rustdoc: don't treat methods under const impls or traits as const)
 - #143394 (compiler: Document and reduce `fn provide`s in hir crates)
 - #143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e080bc8 into rust-lang:master Jul 4, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 4, 2025
rust-timer added a commit that referenced this pull request Jul 4, 2025
Rollup merge of #142749 - LimpSquid:bool_to_result, r=scottmcm

Add methods for converting bool to `Result<(), E>`

## Tracking Issue

#142748

## ACP

rust-lang/libs-team#606
Kobzol pushed a commit to Kobzol/rustc-dev-guide that referenced this pull request Jul 4, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#142749 (Add methods for converting bool to `Result<(), E>`)
 - rust-lang/rust#143288 (Fix `x clean` with a fifo)
 - rust-lang/rust#143307 (Fast path nitpicks)
 - rust-lang/rust#143346 (update coherence example)
 - rust-lang/rust#143356 (use unsigned_abs instead of `abs` on signed int to silence clippy)
 - rust-lang/rust#143370 (remove redundant #[must_use])
 - rust-lang/rust#143378 (simplify receivers for some array method calls)
 - rust-lang/rust#143380 (Replace kw_span by full span for generic const parameters.)
 - rust-lang/rust#143381 (rustdoc: don't treat methods under const impls or traits as const)
 - rust-lang/rust#143394 (compiler: Document and reduce `fn provide`s in hir crates)
 - rust-lang/rust#143395 (Always use the pure Rust fallback instead of `llvm.{maximum,minimum}`)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jul 11, 2025
Add methods for converting bool to `Result<(), E>`

## Tracking Issue

rust-lang#142748

## ACP

rust-lang/libs-team#606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants